Re: [Qemu-devel] [PATCH 5/5] tricore: reset DisasContext before generating code

[Bastian Koppelmann]

Hi,

On 6/5/19 8:11 AM, David Brenken wrote:
> From: Georg Hofstetter <address@hidden>
>
> Signed-off-by: Andreas Konopik <address@hidden>
> Signed-off-by: David Brenken <address@hidden>
> Signed-off-by: Georg Hofstetter <address@hidden>
> Signed-off-by: Robert Rasche <address@hidden>
> Signed-off-by: Lars Biermanski <address@hidden>
>
> ---
>   target/tricore/translate.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/target/tricore/translate.c b/target/tricore/translate.c
> index db09f82c31..cdbc00d654 100644
> --- a/target/tricore/translate.c
> +++ b/target/tricore/translate.c
> @@ -8811,6 +8811,7 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock 
> *tb, int max_insns)
>       target_ulong pc_start;
>       int num_insns = 0;
>   
> +    memset(&ctx, 0x00, sizeof(DisasContext));
>       pc_start = tb->pc;
>       ctx.pc = pc_start;
>       ctx.saved_pc = -1;

To me this looks like fixing a symptom instead of the root cause. Which 
commit did you bisect to? Do you have a reproducer?

Cheers,

Bastian