Re: [Qemu-devel] [PATCH v4 16/39] target/m68k: Use env_cpu, env_archcpu

[Laurent Vivier]

Le 04/06/2019 à 22:33, Richard Henderson a écrit :
> Cleanup in the boilerplate that each target must define.
> Replace m68k_env_get_cpu with env_archcpu.  The combination
> CPU(m68k_env_get_cpu) should have used ENV_GET_CPU to begin;
> use env_cpu now.
> 
> Reviewed-by: Alistair Francis <address@hidden>
> Reviewed-by: Peter Maydell <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  linux-user/m68k/target_cpu.h |  2 +-
>  target/m68k/cpu.h            |  5 -----
>  linux-user/m68k-sim.c        |  3 +--
>  linux-user/m68k/cpu_loop.c   |  2 +-
>  target/m68k/helper.c         | 33 ++++++++++++---------------------
>  target/m68k/m68k-semi.c      |  4 ++--
>  target/m68k/op_helper.c      | 12 ++++++------
>  target/m68k/translate.c      |  4 +---
>  8 files changed, 24 insertions(+), 41 deletions(-)
> 

There is no use of env_archcpu() in this patch, perhaps the comment can
be updated.

Acked-by: Laurent Vivier <address@hidden>

Thanks,
Laurent