Re: [Qemu-devel] [PATCH] block/io_uring: use pkg-config for liburing

[Daniel P . Berrangé]

On Sat, May 25, 2019 at 10:05:59AM +0100, Stefan Hajnoczi wrote:
> Now that liburing has pkg-config support, use it instead of hardcoding
> compiler flags in QEMU's build scripts.  This way distros can customize
> the location of liburing's headers and libraries without requiring
> changes to QEMU.

I was going to say that we should keep the existing code as a fallback
for installs which lack the pkg-config support. It seems liburing is so
new as a project that its not in distros yet. So on that basis we can
justifiably just do pkg-config only and not worry about back compat.

> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>

Reviewed-by: Daniel P. Berrangé <address@hidden>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|