Re: [Qemu-devel] [PATCH v1 0/4] softmmu de-macro fix with tests

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH  v1 0/4] softmmu de-macro fix with tests
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
9a2b8e6 tests/tcg/x86_64: add a PVHVM crt.o for x86_64 system tests
49841ed tests/tcg: clean-up VPATH/TESTS for i386
fd1882e tests/tcg: better detect truncated reads
214a2c9 cputlb: use uint64_t for interim values for unaligned load

=== OUTPUT BEGIN ===
1/4 Checking commit 214a2c99a813 (cputlb: use uint64_t for interim values for 
unaligned load)
2/4 Checking commit fd1882ebd60f (tests/tcg: better detect truncated reads)
ERROR: line over 90 characters
#65: FILE: tests/tcg/multiarch/system/memory.c:273:
+            ml_printf("Error @ %p, more zeros than expected: %d, %d, %d, %d, 
%d, %d, %d, %d",

total: 1 errors, 0 warnings, 84 lines checked

Patch 2/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/4 Checking commit 49841edf7a1f (tests/tcg: clean-up VPATH/TESTS for i386)
4/4 Checking commit 9a2b8e66dabf (tests/tcg/x86_64: add a PVHVM crt.o for 
x86_64 system tests)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

ERROR: line over 90 characters
#82: FILE: tests/tcg/x86_64/system/boot.S:52:
+       ELFNOTE(Xen, XEN_ELFNOTE_PHYS32_ENTRY,   _ASM_PTR _start)    /* entry 
== virtbase */

WARNING: line over 80 characters
#90: FILE: tests/tcg/x86_64/system/boot.S:60:
+       * - `ebx`: contains the physical memory address where the loader has 
placed

WARNING: line over 80 characters
#92: FILE: tests/tcg/x86_64/system/boot.S:62:
+       * - `cr0`: bit 0 (PE) must be set. All the other writeable bits are 
cleared.

WARNING: line over 80 characters
#94: FILE: tests/tcg/x86_64/system/boot.S:64:
+       * - `cs `: must be a 32-bit read/execute code segment with a base of ‘0’

WARNING: line over 80 characters
#95: FILE: tests/tcg/x86_64/system/boot.S:65:
+       *          and a limit of ‘0xFFFFFFFF’. The selector value is 
unspecified.

ERROR: line over 90 characters
#97: FILE: tests/tcg/x86_64/system/boot.S:67:
+       *               ‘0’ and a limit of ‘0xFFFFFFFF’. The selector values 
are all

WARNING: line over 80 characters
#102: FILE: tests/tcg/x86_64/system/boot.S:72:
+       *             Bit 8 (TF) must be cleared. Other bits are all 
unspecified.

WARNING: line over 80 characters
#104: FILE: tests/tcg/x86_64/system/boot.S:74:
+       * All other processor registers and flag bits are unspecified. The OS 
is in

WARNING: line over 80 characters
#157: FILE: tests/tcg/x86_64/system/boot.S:127:
+        /* don't worry about stack frame, assume everthing is garbage when we 
return */

total: 2 errors, 8 warnings, 317 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden