[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 10/17] bios-tables-test: add diff allowed list
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v3 10/17] bios-tables-test: add diff allowed list |
Date: |
Wed, 5 Jun 2019 16:00:31 -0400 |
Expected table change is then handled like this:
1. add table to diff allowed list
2. change generating code (can be combined with 1)
3. maintainer runs a script to update expected +
blows away allowed diff list
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
tests/bios-tables-test-allowed-diff.h | 1 +
tests/bios-tables-test.c | 19 ++++++++++++++++++-
2 files changed, 19 insertions(+), 1 deletion(-)
create mode 100644 tests/bios-tables-test-allowed-diff.h
diff --git a/tests/bios-tables-test-allowed-diff.h
b/tests/bios-tables-test-allowed-diff.h
new file mode 100644
index 0000000000..dfb8523c8b
--- /dev/null
+++ b/tests/bios-tables-test-allowed-diff.h
@@ -0,0 +1 @@
+/* List of comma-separated changed AML files to ignore */
diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index 11e07be093..28d7d427e0 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -342,6 +342,22 @@ try_again:
return exp_tables;
}
+static bool test_acpi_find_diff_allowed(AcpiSdtTable *sdt)
+{
+ const gchar *allowed_diff_file[] = {
+#include "bios-tables-test-allowed-diff.h"
+ NULL
+ };
+ const gchar **f;
+
+ for (f = allowed_diff_file; *f; ++f) {
+ if (!g_strcmp0(sdt->aml_file, *f)) {
+ return true;
+ }
+ }
+ return false;
+}
+
/* test the list of tables in @data->tables against reference tables */
static void test_acpi_asl(test_data *data)
{
@@ -396,7 +412,8 @@ static void test_acpi_asl(test_data *data)
"see ASL difference.");
}
}
- }
+ }
+ g_assert(test_acpi_find_diff_allowed(exp_sdt));
}
g_string_free(asl, true);
g_string_free(exp_asl, true);
--
MST
- [Qemu-devel] [PULL v3 00/17] virtio, pci, pc: cleanups, features, Michael S. Tsirkin, 2019/06/05
- [Qemu-devel] [PULL v3 10/17] bios-tables-test: add diff allowed list,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL v3 14/17] bios-tables-test: list all tables that differ, Michael S. Tsirkin, 2019/06/05
- [Qemu-devel] [PULL v3 17/17] bios-tables-test: ignore identical binaries, Michael S. Tsirkin, 2019/06/05
- Re: [Qemu-devel] [PULL v3 00/17] virtio, pci, pc: cleanups, features, Peter Maydell, 2019/06/06