[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 14/17] bios-tables-test: list all tables that diff
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v3 14/17] bios-tables-test: list all tables that differ |
Date: |
Wed, 5 Jun 2019 16:00:44 -0400 |
Fail after comparing all tables: this way
user gets the full list of tables that need
to be updated or whitelisted.
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
tests/bios-tables-test.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index 28d7d427e0..70895e1014 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -364,7 +364,7 @@ static void test_acpi_asl(test_data *data)
int i;
AcpiSdtTable *sdt, *exp_sdt;
test_data exp_data;
- gboolean exp_err, err;
+ gboolean exp_err, err, all_tables_match = true;
memset(&exp_data, 0, sizeof(exp_data));
exp_data.tables = load_expected_aml(data);
@@ -413,11 +413,13 @@ static void test_acpi_asl(test_data *data)
}
}
}
- g_assert(test_acpi_find_diff_allowed(exp_sdt));
+ all_tables_match = all_tables_match &&
+ test_acpi_find_diff_allowed(exp_sdt);
}
g_string_free(asl, true);
g_string_free(exp_asl, true);
}
+ g_assert(all_tables_match);
free_test_data(&exp_data);
}
--
MST
- [Qemu-devel] [PULL v3 00/17] virtio, pci, pc: cleanups, features, Michael S. Tsirkin, 2019/06/05
- [Qemu-devel] [PULL v3 10/17] bios-tables-test: add diff allowed list, Michael S. Tsirkin, 2019/06/05
- [Qemu-devel] [PULL v3 14/17] bios-tables-test: list all tables that differ,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL v3 17/17] bios-tables-test: ignore identical binaries, Michael S. Tsirkin, 2019/06/05
- Re: [Qemu-devel] [PULL v3 00/17] virtio, pci, pc: cleanups, features, Peter Maydell, 2019/06/06