Re: [Qemu-devel] [PATCH v2 08/10] tests/tcg: target/mips: Add utility function reset_msa_registers()

[Aleksandar Rikalo]

> From: Aleksandar Markovic <address@hidden>
> Sent: Thursday, June 6, 2019 2:24 PM
> To: address@hidden
> Cc: Aleksandar Markovic; Aleksandar Rikalo
> Subject: [PATCH v2 08/10] tests/tcg: target/mips: Add utility function 
> reset_msa_registers()
>
> From: Aleksandar Markovic <address@hidden>
>
> Add function reset_msa_registers() and utilize it in each MSA test.
> This is needed to ensure independency of test results on the state of
> MSA registers before test execution.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---

I don't see the reason why reset_msa_registers() should be nop for now.
It should be implemented right away. Otherwise:

Reviewed-by: Aleksandar Rikalo <address@hidden>

>  tests/tcg/mips/include/wrappers_msa.h                           | 6 ++++++
>  tests/tcg/mips/user/ase/msa/bit-count/test_msa_nloc_b.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-count/test_msa_nloc_d.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-count/test_msa_nloc_h.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-count/test_msa_nloc_w.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-count/test_msa_nlzc_b.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-count/test_msa_nlzc_d.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-count/test_msa_nlzc_h.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-count/test_msa_nlzc_w.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-count/test_msa_pcnt_b.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-count/test_msa_pcnt_d.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-count/test_msa_pcnt_h.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-count/test_msa_pcnt_w.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-set/test_msa_bclr_b.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-set/test_msa_bclr_d.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-set/test_msa_bclr_h.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-set/test_msa_bclr_w.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-set/test_msa_bneg_b.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-set/test_msa_bneg_d.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-set/test_msa_bneg_h.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-set/test_msa_bneg_w.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-set/test_msa_bset_b.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-set/test_msa_bset_d.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-set/test_msa_bset_h.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/bit-set/test_msa_bset_w.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/fixed-multiply/test_msa_mul_q_h.c   | 2 ++
>  tests/tcg/mips/user/ase/msa/fixed-multiply/test_msa_mul_q_w.c   | 2 ++
>  tests/tcg/mips/user/ase/msa/fixed-multiply/test_msa_mulr_q_h.c  | 2 ++
>  tests/tcg/mips/user/ase/msa/fixed-multiply/test_msa_mulr_q_w.c  | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_add_a_b.c          | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_add_a_d.c          | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_add_a_h.c          | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_add_a_w.c          | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_a_b.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_a_d.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_a_h.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_a_w.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_s_b.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_s_d.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_s_h.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_s_w.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_u_b.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_u_d.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_u_h.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_u_w.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_addv_b.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_addv_d.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_addv_h.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_addv_w.c           | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_s_d.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_s_h.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_s_w.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_u_d.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_u_h.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_u_w.c         | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_ave_s_b.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_ave_s_d.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_ave_s_h.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_ave_s_w.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_ave_u_b.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_ave_u_d.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_ave_u_h.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_ave_u_w.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_aver_s_b.c     | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_aver_s_d.c     | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_aver_s_h.c     | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_aver_s_w.c     | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_aver_u_b.c     | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_aver_u_d.c     | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_aver_u_h.c     | 2 ++
>  tests/tcg/mips/user/ase/msa/int-average/test_msa_aver_u_w.c     | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_ceq_b.c        | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_ceq_d.c        | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_ceq_h.c        | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_ceq_w.c        | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_cle_s_b.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_cle_s_d.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_cle_s_h.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_cle_s_w.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_cle_u_b.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_cle_u_d.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_cle_u_h.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_cle_u_w.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_clt_s_b.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_clt_s_d.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_clt_s_h.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_clt_s_w.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_clt_u_b.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_clt_u_d.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_clt_u_h.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-compare/test_msa_clt_u_w.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-divide/test_msa_div_s_b.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-divide/test_msa_div_s_d.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-divide/test_msa_div_s_h.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-divide/test_msa_div_s_w.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-divide/test_msa_div_u_b.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-divide/test_msa_div_u_d.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-divide/test_msa_div_u_h.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-divide/test_msa_div_u_w.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-dot-product/test_msa_dotp_s_d.c | 2 ++
>  tests/tcg/mips/user/ase/msa/int-dot-product/test_msa_dotp_s_h.c | 2 ++
>  tests/tcg/mips/user/ase/msa/int-dot-product/test_msa_dotp_s_w.c | 2 ++
>  tests/tcg/mips/user/ase/msa/int-dot-product/test_msa_dotp_u_d.c | 2 ++
>  tests/tcg/mips/user/ase/msa/int-dot-product/test_msa_dotp_u_h.c | 2 ++
>  tests/tcg/mips/user/ase/msa/int-dot-product/test_msa_dotp_u_w.c | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_max_a_b.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_max_a_d.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_max_a_h.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_max_a_w.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_max_s_b.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_max_s_d.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_max_s_h.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_max_s_w.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_max_u_b.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_max_u_d.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_max_u_h.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_max_u_w.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_min_a_b.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_min_a_d.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_min_a_h.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_min_a_w.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_min_s_b.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_min_s_d.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_min_s_h.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_min_s_w.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_min_u_b.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_min_u_d.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_min_u_h.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-max-min/test_msa_min_u_w.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-modulo/test_msa_mod_s_b.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-modulo/test_msa_mod_s_d.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-modulo/test_msa_mod_s_h.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-modulo/test_msa_mod_s_w.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-modulo/test_msa_mod_u_b.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-modulo/test_msa_mod_u_d.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-modulo/test_msa_mod_u_h.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-modulo/test_msa_mod_u_w.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/int-multiply/test_msa_mulv_b.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-multiply/test_msa_mulv_d.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-multiply/test_msa_mulv_h.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-multiply/test_msa_mulv_w.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_asub_s_b.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_asub_s_d.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_asub_s_h.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_asub_s_w.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_asub_u_b.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_asub_u_d.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_asub_u_h.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_asub_u_w.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_hsub_s_d.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_hsub_s_h.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_hsub_s_w.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_hsub_u_d.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_hsub_u_h.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_hsub_u_w.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subs_s_b.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subs_s_d.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subs_s_h.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subs_s_w.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subs_u_b.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subs_u_d.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subs_u_h.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subs_u_w.c    | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subsus_u_b.c  | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subsus_u_d.c  | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subsus_u_h.c  | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subsus_u_w.c  | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subsuu_s_b.c  | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subsuu_s_d.c  | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subsuu_s_h.c  | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subsuu_s_w.c  | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subv_b.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subv_d.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subv_h.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/int-subtract/test_msa_subv_w.c      | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvev_b.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvev_d.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvev_h.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvev_w.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvl_b.c        | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvl_d.c        | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvl_h.c        | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvl_w.c        | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvod_b.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvod_d.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvod_h.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvod_w.c       | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvr_b.c        | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvr_d.c        | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvr_h.c        | 2 ++
>  tests/tcg/mips/user/ase/msa/interleave/test_msa_ilvr_w.c        | 2 ++
>  tests/tcg/mips/user/ase/msa/logic/test_msa_and_v.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/logic/test_msa_nor_v.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/logic/test_msa_or_v.c               | 2 ++
>  tests/tcg/mips/user/ase/msa/logic/test_msa_xor_v.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/pack/test_msa_pckev_b.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/pack/test_msa_pckev_d.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/pack/test_msa_pckev_h.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/pack/test_msa_pckev_w.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/pack/test_msa_pckod_b.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/pack/test_msa_pckod_d.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/pack/test_msa_pckod_h.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/pack/test_msa_pckod_w.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/pack/test_msa_vshf_b.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/pack/test_msa_vshf_d.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/pack/test_msa_vshf_h.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/pack/test_msa_vshf_w.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sll_b.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sll_d.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sll_h.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sll_w.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sra_b.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sra_d.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sra_h.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_sra_w.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srar_b.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srar_d.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srar_h.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srar_w.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srl_b.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srl_d.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srl_h.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srl_w.c              | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_b.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_d.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_h.c             | 2 ++
>  tests/tcg/mips/user/ase/msa/shift/test_msa_srlr_w.c             | 2 ++
>  227 files changed, 458 insertions(+)
>
> diff --git a/tests/tcg/mips/include/wrappers_msa.h 
> b/tests/tcg/mips/include/wrappers_msa.h
> index 2dc89e4..147dcd0 100644
> --- a/tests/tcg/mips/include/wrappers_msa.h
> +++ b/tests/tcg/mips/include/wrappers_msa.h
> @@ -23,6 +23,12 @@
>  #define WRAPPERS_MSA_H
>
>
> +static inline void reset_msa_registers()
> +{
> +   ; /* nop for now */
> +}
> +
> +
>  #define DO_MSA__WD__WS(suffix, mnemonic)                               \
>  static inline void do_msa_##suffix(const void *input,                  \
>                                     const void *output)                 \