[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/42] decodetree: Fix comparison of Field
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 01/42] decodetree: Fix comparison of Field |
Date: |
Thu, 6 Jun 2019 18:45:28 +0100 |
From: Richard Henderson <address@hidden>
Typo comparing the sign of the field, twice, instead of also comparing
the mask of the field (which itself encodes both position and length).
Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>
---
scripts/decodetree.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index 81874e22cc7..d7a59d63ac3 100755
--- a/scripts/decodetree.py
+++ b/scripts/decodetree.py
@@ -184,7 +184,7 @@ class Field:
return '{0}(insn, {1}, {2})'.format(extr, self.pos, self.len)
def __eq__(self, other):
- return self.sign == other.sign and self.sign == other.sign
+ return self.sign == other.sign and self.mask == other.mask
def __ne__(self, other):
return not self.__eq__(other)
--
2.20.1
- [Qemu-devel] [PATCH 00/42] target/arm: Convert VFP decoder to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 16/42] target/arm: Convert the VFP load/store multiple insns to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 11/42] target/arm: Add helpers for VFP register loads and stores, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 01/42] decodetree: Fix comparison of Field,
Peter Maydell <=
- [Qemu-devel] [PATCH 08/42] target/arm: Convert VRINTA/VRINTN/VRINTP/VRINTM to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 15/42] target/arm: Convert VFP VLDR and VSTR to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 38/42] target/arm: Convert integer-to-float insns to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 26/42] target/arm: Convert VDIV to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 14/42] target/arm: Convert VFP two-register transfer insns to decodetree, Peter Maydell, 2019/06/06