Re: [Qemu-devel] [PATCH v2] m68k comments break patch submission due to being incorrectly formatted

[Lucien Murray-Pitts]

On Fri, Jun 07, 2019 at 01:58:05AM +0200, Aleksandar Markovic wrote:
> On Jun 7, 2019 1:42 AM, "Lucien Murray-Pitts" <address@hidden>
> wrote:
> >
> > Altering all comments in target/m68k to match Qemu coding styles so that
> future
> > patches wont fail due to style breaches.
> >
> 
> Are you saying that patches fail checkpatch checks even if the new code has
> only correct comment format? (Or, in other words, that checkpatch detects
> comment-related errors in  unchanged code, and reports them as the
> errors/warnings in the patch in question?) I just want to understand what
> is the obstacle you are trying to remove.
> 
> Thanks, Aleksandar
> 
[SNIP of PATCH]

checkpatch is correctly identifying the wrong style in the changed code.
This changed code contains the original comments with ADDITIONAL edits
resulting in pachew/checkpatch complaining.

The m68k is, by my guess, older code and nearly all the comments are different
from the style guide.  Some are "/**" or "/*commment here...." and so on.

Since I had a patch AUTO-FLAGGED by patchew for this reason I thought I would
start with a cleanup of the comments to bring them into line with the style.

Cheers,
Luc