Re: [Qemu-devel] [PATCH v1 03/26] tests: Run the iotests during "make check" again

[Alex Bennée]

Alex Bennée <address@hidden> writes:

> From: Thomas Huth <address@hidden>
>
> People often forget to run the iotests before submitting patches or
> pull requests - this is likely due to the fact that we do not run the
> tests during our mandatory "make check" tests yet. Now that we've got
> a proper "auto" group of iotests that should be fine to run in every
> environment, we can enable the iotests during "make check" again by
> running the "auto" tests by default from the check-block.sh script.
>
> Some cases still need to be checked first, though: iotests need bash
> and GNU sed (otherwise they fail), and if gprof is enabled, it spoils
> the output of some test cases causing them to fail. So if we detect
> that one of the required programs is missing or that gprof is enabled,
> we still have to skip the iotests to avoid failures.

Thomas,

I've dropped this from the latest PR because I'm still seeing problems
in some places. One of the issues is tests failing when the underlying
file system doesn't support O_DIRECT. Some tests seem to have explicit
feature checks for this but others just fail.

--
Alex Bennée