[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks |
Date: |
Fri, 07 Jun 2019 14:25:13 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> On 6/7/19 8:59 AM, Markus Armbruster wrote:
> [...]
>> QOM is not a particularly active subsystem now: 51 commits in two years.
>>
>> We obviously need maintainers to review and merge patches. The nominal
>> maintainer hasn't been doing that since 2015. Git shows the following
>> top committers taking on / getting sucked into QOM:
>>
>> Markus Armbruster <address@hidden>
>> Eduardo Habkost <address@hidden>
>> Paolo Bonzini <address@hidden>
>> Marc-André Lureau <address@hidden>
>> Eric Blake <address@hidden>
>>
>> We really need nominal maintainer(s) again.
>>
>> Of course, *active* maintainers would be even better: I consider QOM
>> stuck in an unhappy place where much of its potential is still
>> potential.
>>
>> But let's start small. Volunteers for the reviewer role, please step
>> forward :)
>>
>>
>>
>> The details I promised:
>>
>> Output of "scripts/get_maintainer.pl --git --git-since='2-years-ago' |
>> grep commit_signer" sorted by file size:
>>
> [...]
>> = include/qom/object_interfaces.h =
>> Eduardo Habkost <address@hidden> (commit_signer:8/5=100%)
>> Igor Mammedov <address@hidden> (commit_signer:3/5=60%)
>> "Marc-André Lureau" <address@hidden> (commit_signer:2/5=40%)
>> "Philippe Mathieu-Daudé" <address@hidden> (commit_signer:2/5=40%)
>> Eric Blake <address@hidden> (commit_signer:1/5=20%)
>
> get_maintainer's commit_signer is lying...
Any of Signed-off-by:, Reviewed-by:, Acked-by: counts as
"commit_signer".
[...]
>> = qom/trace-events =
>> Stefan Hajnoczi <address@hidden> (commit_signer:2/2=100%)
>> "Philippe Mathieu-Daudé" <address@hidden> (commit_signer:2/2=100%)
>> Markus Armbruster <address@hidden> (commit_signer:1/2=50%)
>> Michael Tokarev <address@hidden> (commit_signer:1/2=50%)
>
> This 'git log -p' history of this file is very interesting...
Papershuffling...