Re: [Qemu-devel] [PATCH v17 00/24] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v17 00/24] Add RX archtecture support
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
0a86ff5 target/rx: Remove suffix in cpu class.
7c34b40 target/rx: Dump bytes for each insn during disassembly
945fdef target/rx: Collect all bytes during disassembly
9b70cf6 target/rx: Emit all disassembly in one prt()
2b90c06 target/rx: Use prt_ldmi for XCHG_mr disassembly
2b32bfa target/rx: Replace operand with prt_ldmi in disassembler
c1043d7 target/rx: Disassemble rx_index_addr into a string
fffdd29 MAINTAINERS: Add RX
0bbb796 Add rx-softmmu
d93ac92 hw/rx: Honor -accel qtest
fdae244 tests: Add rx to machine-none-test.c
28f5c67 target/rx: Fix cpu types and names
d6dc436 target/rx: Add RX to SysEmuTarget
afe7fba target/rx: Convert to CPUClass::tlb_fill
0a8257b hw/registerfields.h: Add 8bit and 16bit register macros
32020f6 qemu/bitops.h: Add extract8 and extract16
8bdcd32 hw/rx: RX Target hardware definition
129d81c hw/char: RX62N serial communication interface (SCI)
dab747e hw/timer: RX62N internal timer modules
bd0cd17 hw/intc: RX62N interrupt controller (ICUa)
77f42d4 target/rx: RX disassembler
05f2af5 target/rx: CPU definition
16eaad3 target/rx: TCG helper
566ca1e target/rx: TCG translation

=== OUTPUT BEGIN ===
1/24 Checking commit 566ca1e22f98 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 1/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/24 Checking commit 16eaad386caa (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 660 lines checked

Patch 2/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/24 Checking commit 05f2af51dfa8 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 599 lines checked

Patch 3/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/24 Checking commit 77f42d4c2eb2 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 4/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/24 Checking commit bd0cd177ac9d (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 5/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/24 Checking commit dab747e06f0c (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 839 lines checked

Patch 6/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/24 Checking commit 129d81c52450 (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 7/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/24 Checking commit 8bdcd3251fe6 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 460 lines checked

Patch 8/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/24 Checking commit 32020f6289d7 (qemu/bitops.h: Add extract8 and extract16)
10/24 Checking commit 0a8257b1853a (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#25: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#29: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 10/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/24 Checking commit afe7fba60d82 (target/rx: Convert to CPUClass::tlb_fill)
12/24 Checking commit d6dc436c6701 (target/rx: Add RX to SysEmuTarget)
13/24 Checking commit 28f5c6778a28 (target/rx: Fix cpu types and names)
14/24 Checking commit fdae244edeac (tests: Add rx to machine-none-test.c)
15/24 Checking commit d93ac92399b1 (hw/rx: Honor -accel qtest)
16/24 Checking commit 0bbb796e9dd3 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 45 lines checked

Patch 16/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/24 Checking commit fffdd29b15ad (MAINTAINERS: Add RX)
18/24 Checking commit c1043d77d908 (target/rx: Disassemble rx_index_addr into a 
string)
19/24 Checking commit 2b32bfa218e0 (target/rx: Replace operand with prt_ldmi in 
disassembler)
20/24 Checking commit 2b90c0624c57 (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
21/24 Checking commit 9b70cf645d36 (target/rx: Emit all disassembly in one 
prt())
22/24 Checking commit 945fdef6f8e0 (target/rx: Collect all bytes during 
disassembly)
23/24 Checking commit 7c34b40e76c6 (target/rx: Dump bytes for each insn during 
disassembly)
24/24 Checking commit 0a86ff5bb316 (target/rx: Remove suffix in cpu class.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden