[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v17 23/24] target/rx: Dump bytes for each insn d
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v17 23/24] target/rx: Dump bytes for each insn during disassembly |
Date: |
Fri, 7 Jun 2019 15:42:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 6/7/19 11:11 AM, Yoshinori Sato wrote:
> From: Richard Henderson <address@hidden>
>
> There are so many different forms of each RX instruction
> that it will be very useful to be able to look at the bytes
> to see on which path a bug may lie.
>
> Reviewed-by: Yoshinori Sato <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
Again:
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Signed-off-by: Yoshinori Sato <address@hidden>
> ---
> target/rx/disas.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/target/rx/disas.c b/target/rx/disas.c
> index 5a32a87534..d73b53db44 100644
> --- a/target/rx/disas.c
> +++ b/target/rx/disas.c
> @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d)
> /* Include the auto-generated decoder. */
> #include "decode.inc.c"
>
> -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__)
> +static void dump_bytes(DisasContext *ctx)
> +{
> + int i, len = ctx->len;
> +
> + for (i = 0; i < len; ++i) {
> + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]);
> + }
> + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t');
> +}
> +
> +#define prt(...) \
> + do { \
> + dump_bytes(ctx); \
> + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \
> + } while (0)
>
> #define RX_MEMORY_BYTE 0
> #define RX_MEMORY_WORD 1
>
- [Qemu-devel] [PATCH v17 11/24] target/rx: Convert to CPUClass::tlb_fill, (continued)
- [Qemu-devel] [PATCH v17 11/24] target/rx: Convert to CPUClass::tlb_fill, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 10/24] hw/registerfields.h: Add 8bit and 16bit register macros, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 14/24] tests: Add rx to machine-none-test.c, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 24/24] target/rx: Remove suffix in cpu class., Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 18/24] target/rx: Disassemble rx_index_addr into a string, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 08/24] hw/rx: RX Target hardware definition, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 04/24] target/rx: RX disassembler, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 23/24] target/rx: Dump bytes for each insn during disassembly, Yoshinori Sato, 2019/06/07
- Re: [Qemu-devel] [PATCH v17 23/24] target/rx: Dump bytes for each insn during disassembly,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v17 05/24] hw/intc: RX62N interrupt controller (ICUa), Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 19/24] target/rx: Replace operand with prt_ldmi in disassembler, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 13/24] target/rx: Fix cpu types and names, Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 21/24] target/rx: Emit all disassembly in one prt(), Yoshinori Sato, 2019/06/07
- [Qemu-devel] [PATCH v17 09/24] qemu/bitops.h: Add extract8 and extract16, Yoshinori Sato, 2019/06/07