Re: [Qemu-devel] [PATCH v6 0/7] Add "boot_linux" acceptance test

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v6 0/7] Add "boot_linux" acceptance test
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
7362d67bed use Avocado data drainer for console logging
1c6ac71e07 Add "boot_linux" test for aarch64 and virt machine type
76dfc6e28e Add "boot_linux" test for x86_64 and pc and q35 machine types
01a69804c2 Acceptance tests: depend on qemu-img
b7dc969d31 Acceptance tests: add the build directory to the system PATH
5f3b84c3b6 Acceptance tests: keep a stable reference to the QEMU build dir
8d08990c7c Acceptance tests: use relative location for tests

=== OUTPUT BEGIN ===
1/7 Checking commit 8d08990c7c78 (Acceptance tests: use relative location for 
tests)
2/7 Checking commit 5f3b84c3b6f7 (Acceptance tests: keep a stable reference to 
the QEMU build dir)
ERROR: line over 90 characters
#48: FILE: tests/acceptance/avocado_qemu/__init__.py:17:
+SRC_ROOT_DIR = 
os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(__file__))))

total: 1 errors, 0 warnings, 8 lines checked

Patch 2/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/7 Checking commit b7dc969d311a (Acceptance tests: add the build directory to 
the system PATH)
4/7 Checking commit 01a69804c2b2 (Acceptance tests: depend on qemu-img)
5/7 Checking commit 76dfc6e28e21 (Add "boot_linux" test for x86_64 and pc and 
q35 machine types)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

WARNING: line over 80 characters
#107: FILE: tests/acceptance/boot_linux.py:60:
+        cloudinit.wait_for_phone_home(('0.0.0.0', self.phone_home_port), 
self.name)

total: 0 errors, 2 warnings, 96 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/7 Checking commit 1c6ac71e07f2 (Add "boot_linux" test for aarch64 and virt 
machine type)
7/7 Checking commit 7362d67bed37 (use Avocado data drainer for console logging)
WARNING: line over 80 characters
#38: FILE: tests/acceptance/boot_linux.py:62:
+        console_drainer = 
datadrainer.LineLogger(self.vm.console_socket.fileno(),

WARNING: line over 80 characters
#39: FILE: tests/acceptance/boot_linux.py:63:
+                                                 
logger=self.log.getChild('console'))

total: 0 errors, 2 warnings, 50 lines checked

Patch 7/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden