Re: [Qemu-devel] [PATCH 27/42] target/arm: Convert VFP fused multiply-add insns to decodetree

[Richard Henderson]

On 6/6/19 12:45 PM, Peter Maydell wrote:
> +VFM_sp       ---- 1110 1.01 .... .... 1010 . o2:1 . 0 .... \
> +             vm=%vm_sp vn=%vn_sp vd=%vd_sp o1=1
> +VFM_dp       ---- 1110 1.01 .... .... 1011 . o2:1 . 0 .... \
> +             vm=%vm_dp vn=%vn_dp vd=%vd_dp o1=1
> +VFM_sp       ---- 1110 1.10 .... .... 1010 . o2:1 . 0 .... \
> +             vm=%vm_sp vn=%vn_sp vd=%vd_sp o1=2
> +VFM_dp       ---- 1110 1.10 .... .... 1011 . o2:1 . 0 .... \
> +             vm=%vm_dp vn=%vn_dp vd=%vd_dp o1=2

While this is what the ARM names these fields, I wonder if it would be clearer
to rename o2 as neg_vn, and o1<0> as neg_vd.

But what you have isn't wrong, so
Reviewed-by: Richard Henderson <address@hidden>


r~