Re: [Qemu-devel] [PULL 00/39] tcg: Move the softmmu tlb to CPUNegativeOffsetState

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/39] tcg: Move the softmmu tlb to 
CPUNegativeOffsetState
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
f8067abe5e tcg/arm: Remove mostly unreachable tlb special case
b4d1d7bc09 tcg/arm: Use LDRD to load tlb mask+table
be59611fe1 tcg/aarch64: Use LDP to load tlb mask+table
900e66f512 cpu: Remove CPU_COMMON
a4fac0a5bb cpu: Move the softmmu tlb to CPUNegativeOffsetState
592f9cd7be cpu: Move icount_decr to CPUNegativeOffsetState
5d88cb4c74 cpu: Introduce CPUNegativeOffsetState
8738203974 cpu: Introduce cpu_set_cpustate_pointers
c07ad1f754 cpu: Move ENV_OFFSET to exec/gen-icount.h
654b7cd617 target/xtensa: Use env_cpu, env_archcpu
1a04031ecf target/unicore32: Use env_cpu, env_archcpu
b2f0db1902 target/tricore: Use env_cpu
69c740b73e target/tilegx: Use env_cpu
0657035fcf target/sparc: Use env_cpu, env_archcpu
60421aa3ea target/sh4: Use env_cpu, env_archcpu
ef5a6cdf19 target/s390x: Use env_cpu, env_archcpu
1d8cb96d06 target/riscv: Use env_cpu, env_archcpu
bc5af03f86 target/ppc: Use env_cpu, env_archcpu
5169c43239 target/openrisc: Use env_cpu, env_archcpu
b7d6b5a9f3 target/nios2: Use env_cpu, env_archcpu
efb1f9fc5f target/moxie: Use env_cpu, env_archcpu
83010ca82d target/mips: Use env_cpu, env_archcpu
e9df418dae target/microblaze: Use env_cpu, env_archcpu
c6259dfc15 target/m68k: Use env_cpu
0e6090a49a target/lm32: Use env_cpu, env_archcpu
81e38e0ad8 target/i386: Use env_cpu, env_archcpu
b86f02848e target/hppa: Use env_cpu, env_archcpu
d54ea138a2 target/cris: Use env_cpu, env_archcpu
10ae9394cf target/cris: Reindent op_helper.c
c84257154c target/cris: Reindent mmu.c
07655a9400 target/arm: Use env_cpu, env_archcpu
ba6950e065 target/alpha: Use env_cpu, env_archcpu
de1af44772 cpu: Introduce env_archcpu
4b9ceefc2d cpu: Replace ENV_GET_CPU with env_cpu
faf5d63b1f cpu: Define ArchCPU
d8f35b54ce cpu: Define CPUArchState with typedef
78f0658f92 tcg: Create struct CPUTLB
9c7f566b92 tcg: Split out target/arch/cpu-param.h
69a619e5c4 tcg: Fold CPUTLBWindow into CPUTLBDesc

=== OUTPUT BEGIN ===
1/39 Checking commit 69a619e5c449 (tcg: Fold CPUTLBWindow into CPUTLBDesc)
2/39 Checking commit 9c7f566b9239 (tcg: Split out target/arch/cpu-param.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
new file mode 100644

total: 0 errors, 1 warnings, 1290 lines checked

Patch 2/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/39 Checking commit 78f0658f9271 (tcg: Create struct CPUTLB)
4/39 Checking commit d8f35b54ce58 (cpu: Define CPUArchState with typedef)
5/39 Checking commit faf5d63b1f56 (cpu: Define ArchCPU)
6/39 Checking commit 4b9ceefc2d7b (cpu: Replace ENV_GET_CPU with env_cpu)
7/39 Checking commit de1af447722b (cpu: Introduce env_archcpu)
8/39 Checking commit ba6950e06568 (target/alpha: Use env_cpu, env_archcpu)
9/39 Checking commit 07655a940098 (target/arm: Use env_cpu, env_archcpu)
10/39 Checking commit c84257154c78 (target/cris: Reindent mmu.c)
11/39 Checking commit 10ae9394cfc0 (target/cris: Reindent op_helper.c)
12/39 Checking commit d54ea138a2e2 (target/cris: Use env_cpu, env_archcpu)
13/39 Checking commit b86f02848e2b (target/hppa: Use env_cpu, env_archcpu)
14/39 Checking commit 81e38e0ad80e (target/i386: Use env_cpu, env_archcpu)
15/39 Checking commit 0e6090a49a29 (target/lm32: Use env_cpu, env_archcpu)
16/39 Checking commit c6259dfc15bf (target/m68k: Use env_cpu)
17/39 Checking commit e9df418daec8 (target/microblaze: Use env_cpu, env_archcpu)
18/39 Checking commit 83010ca82dd9 (target/mips: Use env_cpu, env_archcpu)
19/39 Checking commit efb1f9fc5fde (target/moxie: Use env_cpu, env_archcpu)
20/39 Checking commit b7d6b5a9f3cb (target/nios2: Use env_cpu, env_archcpu)
21/39 Checking commit 5169c4323929 (target/openrisc: Use env_cpu, env_archcpu)
22/39 Checking commit bc5af03f86cc (target/ppc: Use env_cpu, env_archcpu)
23/39 Checking commit 1d8cb96d06e1 (target/riscv: Use env_cpu, env_archcpu)
24/39 Checking commit ef5a6cdf1928 (target/s390x: Use env_cpu, env_archcpu)
25/39 Checking commit 60421aa3ea7e (target/sh4: Use env_cpu, env_archcpu)
26/39 Checking commit 0657035fcfd2 (target/sparc: Use env_cpu, env_archcpu)
27/39 Checking commit 69c740b73e22 (target/tilegx: Use env_cpu)
28/39 Checking commit b2f0db19026f (target/tricore: Use env_cpu)
29/39 Checking commit 1a04031ecf68 (target/unicore32: Use env_cpu, env_archcpu)
30/39 Checking commit 654b7cd617d8 (target/xtensa: Use env_cpu, env_archcpu)
31/39 Checking commit c07ad1f7547c (cpu: Move ENV_OFFSET to exec/gen-icount.h)
32/39 Checking commit 873820397469 (cpu: Introduce cpu_set_cpustate_pointers)
33/39 Checking commit 5d88cb4c7400 (cpu: Introduce CPUNegativeOffsetState)
34/39 Checking commit 592f9cd7bedf (cpu: Move icount_decr to 
CPUNegativeOffsetState)
ERROR: return is not a function, parentheses are not required
#193: FILE: cpus.c:242:
+    return (cpu->icount_budget -

total: 1 errors, 0 warnings, 326 lines checked

Patch 34/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

35/39 Checking commit a4fac0a5bbd0 (cpu: Move the softmmu tlb to 
CPUNegativeOffsetState)
36/39 Checking commit 900e66f512dc (cpu: Remove CPU_COMMON)
37/39 Checking commit be59611fe106 (tcg/aarch64: Use LDP to load tlb mask+table)
38/39 Checking commit b4d1d7bc09ca (tcg/arm: Use LDRD to load tlb mask+table)
39/39 Checking commit f8067abe5e3d (tcg/arm: Remove mostly unreachable tlb 
special case)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden