Re: [Qemu-devel] [PATCH v3 3/8] tests: Add migration multifd test

[Juan Quintela]

Wei Yang <address@hidden> wrote:
> On Wed, May 15, 2019 at 02:15:39PM +0200, Juan Quintela wrote:
>>We set multifd-channels.
>>
>>Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>>Reviewed-by: Thomas Huth <address@hidden>
>>Signed-off-by: Juan Quintela <address@hidden>
>>---
>> tests/migration-test.c | 48 ++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 48 insertions(+)
>>
>>diff --git a/tests/migration-test.c b/tests/migration-test.c
>>index 0b25aa3d6c..ff480e0682 100644
>>--- a/tests/migration-test.c
>>+++ b/tests/migration-test.c
>>@@ -1028,6 +1028,53 @@ static void test_precopy_tcp(void)
>>     g_free(uri);
>> }
>> 
>>+static void test_multifd_tcp(void)
>>+{
>>+    char *uri;
>>+    QTestState *from, *to;
>>+
>>+    if (test_migrate_start(&from, &to, "tcp:127.0.0.1:0", false, false)) {
>>+        return;
>>+    }
>>+
>>+    /*
>>+     * We want to pick a speed slow enough that the test completes
>>+     * quickly, but that it doesn't complete precopy even on a slow
>>+     * machine, so also set the downtime.
>>+     */
>>+    /* 1 ms should make it not converge*/
>>+    migrate_set_parameter_int(from, "downtime-limit", 1);
>>+    /* 1GB/s */
>>+    migrate_set_parameter_int(from, "max-bandwidth", 1000000000);
>>+
>>+    migrate_set_parameter_int(from, "multifd-channels", 2);
>>+    migrate_set_parameter_int(to, "multifd-channels", 2);
>>+
>>+    migrate_set_capability(from, "multifd", "true");
>>+    migrate_set_capability(to, "multifd", "true");
>
> Hi, Juan
>
> In case to test multifd, what's the minimum configuration? Set multifd
> capability at both side is fine?

It is required.  For older configuration, we are a bit more lax about
that requirement.  For anything new, we want it to be set in both sides.

Thanks, Juan.