[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress paramete
|
From: |
Juan Quintela |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter |
|
Date: |
Mon, 10 Jun 2019 11:42:54 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Wei Yang <address@hidden> wrote:
> On Wed, May 15, 2019 at 02:15:41PM +0200, Juan Quintela wrote:
>>Signed-off-by: Juan Quintela <address@hidden>
>>@@ -1821,6 +1826,18 @@ void hmp_migrate_set_parameter(Monitor *mon, const
>>QDict *qdict)
>> p->has_multifd_channels = true;
>> visit_type_int(v, param, &p->multifd_channels, &err);
>> break;
>>+ case MIGRATION_PARAMETER_MULTIFD_COMPRESS:
>>+ p->has_multifd_compress = true;
>>+ visit_type_MultifdCompress(v, param, &compress_type, &err);
>>+ if (err) {
>>+ break;
>>+ }
>>+ if (compress_type < 0 || compress_type >= MULTIFD_COMPRESS__MAX) {
>
> A warning during build:
>
> hmp.c:1835:27: warning: comparison of unsigned enum expression < 0 is
> always false [-Wtautological-compare]
> if (compress_type < 0 || compress_type >= MULTIFD_COMPRESS__MAX) {
Fixed, see Markus reason for dropping this bit.
/me wonders why this didn't failed my compilation ....
Thanks, Juan.