Re: [Qemu-devel] [RFC PATCH 0/7] Proof of concept for Meson integration

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [RFC PATCH 0/7] Proof of concept for Meson integration
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
   6960005212..19735c837a  master     -> master
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
d681fb0695 rdmacm-mux: convert to Meson
2c12fcafd1 vhost-user-scsi: convert to Meson
7b87823a4c vhost-user-blk: convert to Meson
45233abe03 libvhost-user: convert to Meson
090f670ef8 configure: integrate Meson in the build system
9d9a4b1926 configure: set $PYTHON to a full path
d47d1b7f13 configure: do not include $(...) variables in config-host.mak

=== OUTPUT BEGIN ===
1/7 Checking commit d47d1b7f1366 (configure: do not include $(...) variables in 
config-host.mak)
2/7 Checking commit 9d9a4b192614 (configure: set $PYTHON to a full path)
3/7 Checking commit 090f670ef84c (configure: integrate Meson in the build 
system)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#104: 
new file mode 100644

WARNING: line over 80 characters
#283: FILE: scripts/ninjatool.py:160:
+        raise LexerError("%s:%d: %s" % (self.stack[-1].filename, self.lineno, 
msg))

WARNING: line over 80 characters
#286: FILE: scripts/ninjatool.py:163:
+        raise ParseError("%s:%d: %s" % (self.stack[-1].filename, self.lineno, 
msg))

ERROR: line over 90 characters
#668: FILE: scripts/ninjatool.py:545:
+        self.scope = BuildScope(self, out, iout, rule, in_, iin, orderdep, 
self.rule_vars[rule])

WARNING: line over 80 characters
#703: FILE: scripts/ninjatool.py:580:
+    ARGS = argparse.ArgumentParser(description='Rewrite input build.ninja to 
stdout.')

WARNING: line over 80 characters
#738: FILE: scripts/ninjatool.py:615:
+    def begin_build(self, outputs, implicit_outputs, rule, inputs, implicit, 
order_only):

WARNING: line over 80 characters
#843: FILE: scripts/ninjatool.py:720:
+    ARGS = argparse.ArgumentParser(description='Convert build.ninja to a 
Makefile.')

ERROR: line over 90 characters
#897: FILE: scripts/ninjatool.py:774:
+            self.print(r'ninja-clean:: ninja-clean-start; $(if $V,,@)rm -f 
${ninja-depfiles}')

ERROR: line over 90 characters
#911: FILE: scripts/ninjatool.py:788:
+        self.print(r"ninja-command = $(if $V,,@printf '%s\n' '$(subst 
','\'',${.var.description})' && )${.var.command}")

ERROR: line over 90 characters
#937: FILE: scripts/ninjatool.py:814:
+            self.print('ninja-targets-%s := %s' % (rule, ' 
'.join(self.rule_targets[rule])))

ERROR: line over 90 characters
#939: FILE: scripts/ninjatool.py:816:
+                self.print('$(ninja-targets-%s): .var.%s = %s' % (rule, name, 
self.mangle_vars_for_make(value)))

WARNING: line over 80 characters
#940: FILE: scripts/ninjatool.py:817:
+            self.print('ninja-outputdirs += $(sort $(dir 
${ninja-targets-%s}))' % rule)

WARNING: line over 80 characters
#951: FILE: scripts/ninjatool.py:828:
+            default_targets = sorted(self.all_outs - self.all_ins, 
key=natural_sort_key)

WARNING: line over 80 characters
#960: FILE: scripts/ninjatool.py:837:
+        phony_targets = sorted(self.all_phony - self.all_ins, 
key=natural_sort_key)

WARNING: line over 80 characters
#969: FILE: scripts/ninjatool.py:846:
+            # These have to be printed last, because they override rule 
variables

WARNING: line over 80 characters
#970: FILE: scripts/ninjatool.py:847:
+            # but we cannot print rule variables until we know the list of 
targets

WARNING: line over 80 characters
#972: FILE: scripts/ninjatool.py:849:
+            self.build_vars[self.current_targets][name] = 
self.scope.build_vars[name]

WARNING: line over 80 characters
#991: FILE: scripts/ninjatool.py:868:
+                             self.scope.in_ + self.scope.iin + 
self.scope.orderdep)

WARNING: line over 80 characters
#998: FILE: scripts/ninjatool.py:875:
+        self.print('%s: %s | %s; ${ninja-command}' % (targets, inputs, 
orderonly))

ERROR: line over 90 characters
#1024: FILE: scripts/ninjatool.py:901:
+    def __init__(self, option_strings, dest, choices, metavar='TOOL', 
nargs=None, **kwargs):

WARNING: line over 80 characters
#1057: FILE: scripts/ninjatool.py:934:
+parser = argparse.ArgumentParser(description='Process and transform 
build.ninja files.',

total: 6 errors, 15 warnings, 1048 lines checked

Patch 3/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/7 Checking commit 45233abe03bb (libvhost-user: convert to Meson)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#73: 
deleted file mode 100644

total: 0 errors, 1 warnings, 58 lines checked

Patch 4/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/7 Checking commit 7b87823a4cbe (vhost-user-blk: convert to Meson)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#73: 
deleted file mode 100644

total: 0 errors, 1 warnings, 49 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/7 Checking commit 2c12fcafd119 (vhost-user-scsi: convert to Meson)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#62: 
deleted file mode 100644

total: 0 errors, 1 warnings, 44 lines checked

Patch 6/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/7 Checking commit d681fb0695f1 (rdmacm-mux: convert to Meson)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
deleted file mode 100644

total: 0 errors, 1 warnings, 48 lines checked

Patch 7/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden