[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests/tcg/s390x: Fix alignment of csst paramete
|
From: |
David Hildenbrand |
|
Subject: |
Re: [Qemu-devel] [PATCH] tests/tcg/s390x: Fix alignment of csst parameter list |
|
Date: |
Tue, 11 Jun 2019 15:06:36 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 10.06.19 03:42, Richard Henderson wrote:
> The parameter list given in general register 1 shall be aligned
> on a quadword boundary. This test currently succeeds or fails
> depending on the compiler version used and the accidential layout
> of the function's stack frame.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> tests/tcg/s390x/csst.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tcg/s390x/csst.c b/tests/tcg/s390x/csst.c
> index 1dae9071fb..084d80af49 100644
> --- a/tests/tcg/s390x/csst.c
> +++ b/tests/tcg/s390x/csst.c
> @@ -3,7 +3,7 @@
>
> int main(void)
> {
> - uint64_t parmlist[] = {
> + uint64_t parmlist[] __attribute__((aligned(16))) = {
> 0xfedcba9876543210ull,
> 0,
> 0x7777777777777777ull,
>
Reviewed-by: David Hildenbrand <address@hidden>
Queuing it to
https://github.com/davidhildenbrand/qemu.git s390-tcg-next
for now. Let me know if you want to send this via a different PULL
request yourself.
--
Thanks,
David / dhildenb