Re: [Qemu-devel] [PATCH] migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS

[Juan Quintela]

Wei Yang <address@hidden> wrote:
> On receiving RAM_SAVE_FLAG_EOS, multifd_recv_sync_main() is called to
> synchronize receive threads. Current synchronization mechanism is to wait
> for each channel's sem_sync semaphore. This semaphore is triggered by a
> packet with MULTIFD_FLAG_SYNC flag. While in current implementation, we
> don't do multifd_send_sync_main() to send such packet when
> blk_mig_bulk_active() is true.
>
> This will leads to the receive threads won't notify
> multifd_recv_sync_main() by sem_sync. And multifd_recv_sync_main() will
> always wait there.
>
> [Note]: normal migration test works, while didn't test the
> blk_mig_bulk_active() case. Since not sure how to produce this
> situation.
>
> Signed-off-by: Wei Yang <address@hidden>

Reviewed-by: Juan Quintela <address@hidden>

Block migration is weird.
Block migration is weird.
....