[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] migration/xbzrle: make xbzrle_encode_buffer
|
From: |
Wei Yang |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] migration/xbzrle: make xbzrle_encode_buffer little easier to read |
|
Date: |
Wed, 12 Jun 2019 15:02:27 +0000 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, Jun 12, 2019 at 12:29:27PM +0200, Juan Quintela wrote:
>"Dr. David Alan Gilbert" <address@hidden> wrote:
>> * Wei Yang (address@hidden) wrote:
>>> The encoding process could be described below:
>>>
>>> for [content]
>>> get length of a run
>>> encode this run
>>>
>>> By refactoring the code with this logic, it maybe a little easier to
>>> understand.
>>>
>>
>> Are lines like this really making it easier to read?
>>
>> Juan: Opinion?
>
>Code is easier to understand .....
>
>For values that I understand the code. I need to take a big breath and
>will take a deep look at it and see if it really does the same.
>
Haha, thanks for your feedback.
>Later, Juan.
--
Wei Yang
Help you, Help me