Re: [Qemu-devel] [PATCH v2 05/15] target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c

[Richard Henderson]

On 6/2/19 4:08 AM, Mark Cave-Ayland wrote:
> Rather than perform the VSR register decoding within the helper itself,
> introduce a new GEN_VSX_HELPER_X3 macro which performs the decode based
> upon xT, xA and xB at translation time.
> 
> With the previous changes to the VSX_CMP generator and helper macros the
> opcode parameter is no longer required in the common case and can be
> removed.
> 
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
>  target/ppc/fpu_helper.c             |  42 ++++-------
>  target/ppc/helper.h                 | 120 +++++++++++++++----------------
>  target/ppc/translate/vsx-impl.inc.c | 137 
> ++++++++++++++++++++----------------
>  3 files changed, 151 insertions(+), 148 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~