Re: [Qemu-devel] [PATCH v2 10/15] target/ppc: introduce GEN_VSX_HELPER_R3 macro to fpu_helper.c

[Richard Henderson]

On 6/2/19 4:08 AM, Mark Cave-Ayland wrote:
> Rather than perform the VSR register decoding within the helper itself,
> introduce a new GEN_VSX_HELPER_R3 macro which performs the decode based
> upon rD, rA and rB at translation time.
> 
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
>  target/ppc/fpu_helper.c             | 36 ++++++++++++------------------------
>  target/ppc/helper.h                 | 16 ++++++++--------
>  target/ppc/translate/vsx-impl.inc.c | 36 ++++++++++++++++++++++++++++--------
>  3 files changed, 48 insertions(+), 40 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~