[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/7] iotests: Valgrind fails to work with non
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/7] iotests: Valgrind fails to work with nonexistent directory |
Date: |
Thu, 13 Jun 2019 09:52:24 +0000 |
11.06.2019 21:02, Andrey Shinkevich wrote:
> The Valgrind uses the exported variable TMPDIR and fails if the
> directory does not exist. Let us exclude such a test case from
> being run under the Valgrind.
>
> Signed-off-by: Andrey Shinkevich <address@hidden>
Hmm, isn't it preferable to skip unsupported by
valgrind iotests, instead silently disable valgrind in them?
> ---
> tests/qemu-iotests/051 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
> index 200660f..ccc5bc2 100755
> --- a/tests/qemu-iotests/051
> +++ b/tests/qemu-iotests/051
> @@ -377,6 +377,7 @@ printf %b "qemu-io $device_id \"write -P 0x33 0
> 4k\"\ncommit $device_id\n" |
> $QEMU_IO -c "read -P 0x33 0 4k" "$TEST_IMG" | _filter_qemu_io
>
> # Using snapshot=on with a non-existent TMPDIR
(you can add into comment: "Valgrind needs TMPDIR, so disable it"
> +VALGRIND_QEMU="" \
> TMPDIR=/nonexistent run_qemu -drive driver=null-co,snapshot=on
>
> # Using snapshot=on together with read-only=on
>
--
Best regards,
Vladimir
- Re: [Qemu-devel] [PATCH v2 2/7] iotests: exclude killed processes from running under Valgrind, (continued)
[Qemu-devel] [PATCH v2 5/7] iotests: extend sleeping time under Valgrind, Andrey Shinkevich, 2019/06/11
[Qemu-devel] [PATCH v2 6/7] iotests: amend QEMU NBD process synchronization, Andrey Shinkevich, 2019/06/11
[Qemu-devel] [PATCH v2 3/7] iotests: Valgrind fails to work with nonexistent directory, Andrey Shinkevich, 2019/06/11
- Re: [Qemu-devel] [PATCH v2 3/7] iotests: Valgrind fails to work with nonexistent directory,
Vladimir Sementsov-Ogievskiy <=
[Qemu-devel] [PATCH v2 4/7] iotests: extended timeout under Valgrind, Andrey Shinkevich, 2019/06/11
[Qemu-devel] [PATCH v2 1/7] iotests: allow Valgrind checking all QEMU processes, Andrey Shinkevich, 2019/06/11