Re: [Qemu-devel] [PATCH v5 12/42] block: Use bdrv_filtered_rw* where obvious

[Vladimir Sementsov-Ogievskiy]

13.06.2019 1:09, Max Reitz wrote:
> Places that use patterns like
> 
>      if (bs->drv->is_filter && bs->file) {
>          ... something about bs->file->bs ...
>      }
> 
> should be
> 
>      BlockDriverState *filtered = bdrv_filtered_rw_bs(bs);
>      if (filtered) {
>          ... something about @filtered ...
>      }
> 
> instead.

Hmm, in other words, support filters with backing child in all places, where 
only file-based
filters are supported, as we don't want make any semantic difference between 
these two
types of filters.

> 
> Signed-off-by: Max Reitz <address@hidden>

Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>



-- 
Best regards,
Vladimir