[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/9] qemu-nbd: Do not close stderr
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PULL 3/9] qemu-nbd: Do not close stderr |
Date: |
Thu, 13 Jun 2019 10:48:31 -0500 |
From: Max Reitz <address@hidden>
We kept old_stderr specifically so we could keep emitting error message
on stderr. However, qemu_daemon() closes stderr. Therefore, we need to
dup() stderr to old_stderr before invoking qemu_daemon().
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eric Blake <address@hidden>
---
qemu-nbd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 99377a3f14e2..a8cb39e51043 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -1004,10 +1004,11 @@ int main(int argc, char **argv)
exit(EXIT_FAILURE);
} else if (pid == 0) {
close(stderr_fd[0]);
+
+ old_stderr = dup(STDERR_FILENO);
ret = qemu_daemon(1, 0);
/* Temporarily redirect stderr to the parent's pipe... */
- old_stderr = dup(STDERR_FILENO);
dup2(stderr_fd[1], STDERR_FILENO);
if (ret < 0) {
error_report("Failed to daemonize: %s", strerror(errno));
--
2.20.1
- [Qemu-devel] [PULL 0/9] NBD patches through 2019-06-13, Eric Blake, 2019/06/13
- [Qemu-devel] [PULL 3/9] qemu-nbd: Do not close stderr,
Eric Blake <=
- [Qemu-devel] [PULL 5/9] iotests: Let 233 run concurrently, Eric Blake, 2019/06/13
- [Qemu-devel] [PULL 7/9] block/nbd-client: drop stale logout, Eric Blake, 2019/06/13
- [Qemu-devel] [PULL 4/9] iotests: Use qemu-nbd's --pid-file, Eric Blake, 2019/06/13
- [Qemu-devel] [PULL 6/9] nbd/server: Nicer spelling of max BLOCK_STATUS reply length, Eric Blake, 2019/06/13
- [Qemu-devel] [PULL 2/9] iotests.py: Add qemu_nbd_early_pipe(), Eric Blake, 2019/06/13
- [Qemu-devel] [PULL 1/9] qemu-nbd: Add --pid-file option, Eric Blake, 2019/06/13
- [Qemu-devel] [PULL 9/9] block/nbd: merge NBDClientSession struct back to BDRVNBDState, Eric Blake, 2019/06/13
- [Qemu-devel] [PULL 8/9] block/nbd: merge nbd-client.* to nbd.c, Eric Blake, 2019/06/13
- Re: [Qemu-devel] [PULL 0/9] NBD patches through 2019-06-13, Peter Maydell, 2019/06/13