[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh |
Date: |
Fri, 14 Jun 2019 12:13:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 6/14/19 11:42 AM, Kevin Wolf wrote:
> Am 13.06.2019 um 21:41 hat Stefan Weil geschrieben:
>> On 12.06.19 15:27, Philippe Mathieu-Daudé wrote:
>>> Cc'ing Alex (Docker, Travis) and Stefan (MinGW)
>> [...]
>>> Note, libssh is not available on MinGW.
>>
>> Nor is it available for Mingw64:
Yes, by "MinGW" I mean both 32/64 implementations.
>>
>> https://cygwin.com/cgi-bin2/package-grep.cgi?grep=mingw64-x86_64-libssh&arch=x86_64
>>
>> That makes building for Windows more difficult because there is an
>> additional dependency which must be built from source.
>
> How many people do actually use the ssh block driver on Windows, though?
> Isn't just building QEMU without it a quite reasonable option, too?
>
> I wouldn't consider this a strong argument why we should keep using an
> obsolete library.
I agree with Kevin. The only user of the 'ssh' block driver that I am
aware of is the virt-v2v tool:
http://libguestfs.org/virt-v2v.1.html#convert-from-esxi-hypervisor-over-ssh-to-local-libvirt
Stefan, do you think someone would use it on a Windows host?
Thanks,
Phil.
- Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh, (continued)
Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh, Philippe Mathieu-Daudé, 2019/06/12
Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh, Pino Toscano, 2019/06/14