Re: [Qemu-devel] [PATCH v1 1/2] s390x/cpumodel: Rework CPU feature definition

[Cornelia Huck]

On Wed, 12 Jun 2019 15:25:25 +0200
David Hildenbrand <address@hidden> wrote:

> Let's define features at a single spot and make it less error prone to
> define new features.
> 
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  target/s390x/cpu_features.c         | 352 +-------------------------
>  target/s390x/cpu_features_def.h     | 352 +-------------------------
>  target/s390x/cpu_features_def.inc.h | 369 ++++++++++++++++++++++++++++
>  3 files changed, 386 insertions(+), 687 deletions(-)
>  create mode 100644 target/s390x/cpu_features_def.inc.h

Yes, let's get rid of the need to define this in two places.

Acked-by: Cornelia Huck <address@hidden>