[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/8] VNC Acceptance test: simplify test names
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 6/8] VNC Acceptance test: simplify test names |
Date: |
Fri, 14 Jun 2019 16:18:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 6/7/19 5:22 PM, Cleber Rosa wrote:
> The test name is composed of the class name and method name, so it
> looks like there's some redundancy here that we can eliminate.
>
> Signed-off-by: Cleber Rosa <address@hidden>
> ---
> tests/acceptance/vnc.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/acceptance/vnc.py b/tests/acceptance/vnc.py
> index 675fd507ed..d32ae46685 100644
> --- a/tests/acceptance/vnc.py
> +++ b/tests/acceptance/vnc.py
> @@ -45,7 +45,7 @@ class VncUnixSocket(Test):
> self.socket_dir = tempfile.mkdtemp()
> self.socket_path = os.path.join(self.socket_dir, 'vnc-socket')
>
> - def test_vnc_change_password_requires_a_password(self):
> + def test_change_password_requires_a_password(self):
> self.vm.add_args('-nodefaults', '-S',
> '-vnc', 'unix:%s' % self.socket_path)
> self.vm.launch()
> @@ -60,7 +60,7 @@ class VncUnixSocket(Test):
> self.assertEqual(set_password_response['error']['desc'],
> 'Could not set password')
>
> - def test_vnc_change_password(self):
> + def test_change_password(self):
> self.vm.add_args('-nodefaults', '-S',
> '-vnc', 'unix:%s,password' % self.socket_path)
> self.vm.launch()
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>