[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 21/42] block: Use CAFs for debug breakpoints
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 21/42] block: Use CAFs for debug breakpoints |
|
Date: |
Fri, 14 Jun 2019 18:12:23 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 14.06.19 17:29, Vladimir Sementsov-Ogievskiy wrote:
> 13.06.2019 1:09, Max Reitz wrote:
>> When looking for a blkdebug node (which implements debug breakpoints),
>> use bdrv_primary_bs() to iterate through the graph, because that is
>> where a blkdebug node would be.
>>
>> Signed-off-by: Max Reitz <address@hidden>
>
> Honestly, don't know why blkdebug is always searched in ->file sequence,
Usually, blkdebug is just above the protocol node. So
$format --file--> $protocol
becomes
$format --file--> blkdebug --file--> $protocol
This is why the existing code generally looks for blkdebug under the
->file link.
Max
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v5 15/42] block: Re-evaluate backing file handling in reopen, (continued)
[Qemu-devel] [PATCH v5 16/42] block: Use child access functions when flushing, Max Reitz, 2019/06/12
[Qemu-devel] [PATCH v5 17/42] block: Use CAFs in bdrv_refresh_limits(), Max Reitz, 2019/06/12
[Qemu-devel] [PATCH v5 18/42] block: Use CAFs in bdrv_refresh_filename(), Max Reitz, 2019/06/12
[Qemu-devel] [PATCH v5 21/42] block: Use CAFs for debug breakpoints, Max Reitz, 2019/06/12
[Qemu-devel] [PATCH v5 20/42] block/snapshot: Fall back to storage child, Max Reitz, 2019/06/12
[Qemu-devel] [PATCH v5 23/42] blockdev: Use CAF in external_snapshot_prepare(), Max Reitz, 2019/06/12
[Qemu-devel] [PATCH v5 22/42] block: Use CAFs in bdrv_get_allocated_file_size(), Max Reitz, 2019/06/12