Re: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
ddea93d BootLinuxConsoleTest: Test the RX-Virt machine
74f0940 MAINTAINERS: Add RX
f3106ec Add rx-softmmu
1da40c3 hw/registerfields.h: Add 8bit and 16bit register macros
dd11e46 qemu/bitops.h: Add extract8 and extract16
8a27bba hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
710d25f hw/rx: Honor -accel qtest
8e145d9 target/rx: Move rx_load_image to rx-virt.
14b0bc0 hw/rx: RX Target hardware definition
cad9f7e hw/char: RX62N serial communication interface (SCI)
655bc26 hw/timer: RX62N internal timer modules
2309a1e hw/intc: RX62N interrupt controller (ICUa)
3ce6f15 target/rx: Dump bytes for each insn during disassembly
ecaf009 target/rx: Collect all bytes during disassembly
da34fac target/rx: Emit all disassembly in one prt()
84dc86b target/rx: Use prt_ldmi for XCHG_mr disassembly
5ff8a73 target/rx: Replace operand with prt_ldmi in disassembler
16dddb8 target/rx: Disassemble rx_index_addr into a string
77fa9a2 target/rx: RX disassembler
a3b3f57 target/rx: simplify rx_cpu_class_by_name
e93acbf target/rx: Follow the change of tcg.
bc35b11 target/rx: CPU definition
14b01de target/rx: TCG helper
a804cd0 target/rx: TCG translation

=== OUTPUT BEGIN ===
1/24 Checking commit a804cd0b4fd9 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 1/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/24 Checking commit 14b01de07ded (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 649 lines checked

Patch 2/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/24 Checking commit bc35b111d3a8 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 645 lines checked

Patch 3/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/24 Checking commit e93acbf0f80d (target/rx: Follow the change of tcg.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 121 lines checked

Patch 4/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/24 Checking commit a3b3f57d12ee (target/rx: simplify rx_cpu_class_by_name)
6/24 Checking commit 77fa9a20f924 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 6/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/24 Checking commit 16dddb8ce3b2 (target/rx: Disassemble rx_index_addr into a 
string)
8/24 Checking commit 5ff8a73eff90 (target/rx: Replace operand with prt_ldmi in 
disassembler)
9/24 Checking commit 84dc86be8458 (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
10/24 Checking commit da34fac0381b (target/rx: Emit all disassembly in one 
prt())
11/24 Checking commit ecaf00999e83 (target/rx: Collect all bytes during 
disassembly)
12/24 Checking commit 3ce6f15d90a7 (target/rx: Dump bytes for each insn during 
disassembly)
13/24 Checking commit 2309a1e755d6 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 13/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/24 Checking commit 655bc261bf4f (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 839 lines checked

Patch 14/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/24 Checking commit cad9f7ebe6b7 (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 15/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/24 Checking commit 14b0bc079779 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 457 lines checked

Patch 16/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/24 Checking commit 8e145d92702b (target/rx: Move rx_load_image to rx-virt.)
18/24 Checking commit 710d25f068a8 (hw/rx: Honor -accel qtest)
19/24 Checking commit 8a27bba4074b (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
20/24 Checking commit dd11e4699dff (qemu/bitops.h: Add extract8 and extract16)
21/24 Checking commit 1da40c39cf3f (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 21/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

22/24 Checking commit f3106ec3c30f (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 73 lines checked

Patch 22/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/24 Checking commit 74f09405da49 (MAINTAINERS: Add RX)
24/24 Checking commit ddea93d70b87 (BootLinuxConsoleTest: Test the RX-Virt 
machine)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden