[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/5] virtio: Set "start_on_kick" for legacy d
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/5] virtio: Set "start_on_kick" for legacy devices |
Date: |
Sun, 16 Jun 2019 19:27:08 +0200 |
On Fri, 14 Jun 2019 17:31:18 +0800
address@hidden wrote:
> From: Xie Yongji <address@hidden>
>
> Besides virtio 1.0 transitional devices, we should also
> set "start_on_kick" flag for legacy devices (virtio 0.9).
>
> Signed-off-by: Xie Yongji <address@hidden>
> ---
Reviewed-by: Greg Kurz <address@hidden>
> hw/virtio/virtio.c | 6 ++----
> include/hw/virtio/virtio.h | 2 +-
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index 19062fbb96..473881e9ec 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -1212,8 +1212,7 @@ void virtio_reset(void *opaque)
> k->reset(vdev);
> }
>
> - vdev->start_on_kick = (virtio_host_has_feature(vdev, VIRTIO_F_VERSION_1)
> &&
> - !virtio_vdev_has_feature(vdev,
> VIRTIO_F_VERSION_1));
> + vdev->start_on_kick = !virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1);
> vdev->started = false;
> vdev->broken = false;
> vdev->guest_features = 0;
> @@ -2325,8 +2324,7 @@ void virtio_init(VirtIODevice *vdev, const char *name,
> g_malloc0(sizeof(*vdev->vector_queues) * nvectors);
> }
>
> - vdev->start_on_kick = (virtio_host_has_feature(vdev, VIRTIO_F_VERSION_1)
> &&
> - !virtio_vdev_has_feature(vdev,
> VIRTIO_F_VERSION_1));
> + vdev->start_on_kick = !virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1);
> vdev->started = false;
> vdev->device_id = device_id;
> vdev->status = 0;
> diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
> index 15d5366939..b189788cb2 100644
> --- a/include/hw/virtio/virtio.h
> +++ b/include/hw/virtio/virtio.h
> @@ -107,7 +107,7 @@ struct VirtIODevice
> bool broken; /* device in invalid state, needs reset */
> bool use_started;
> bool started;
> - bool start_on_kick; /* virtio 1.0 transitional devices support that */
> + bool start_on_kick; /* when virtio 1.0 feature has not been negotiated */
> VMChangeStateEntry *vmstate;
> char *bus_name;
> uint8_t device_endian;
[Qemu-devel] [PATCH v3 3/5] virtio: Set "start_on_kick" on virtio_set_features(), elohimes, 2019/06/14
[Qemu-devel] [PATCH v3 2/5] virtio: Set "start_on_kick" for legacy devices, elohimes, 2019/06/14
- Re: [Qemu-devel] [PATCH v3 2/5] virtio: Set "start_on_kick" for legacy devices,
Greg Kurz <=