[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] xen: Avoid VLA
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] xen: Avoid VLA |
Date: |
Mon, 17 Jun 2019 18:36:49 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Mon, Jun 17, 2019 at 05:39:09PM +0100, Paul Durrant wrote:
> > @@ -632,6 +633,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state,
> > return;
> > }
> >
> > + bitmap = g_new0(unsigned long, bitmap_size);
> > +
>
> How hot is this function? It looks (unsurprisingly) like the section
> size determines the map size so I wonder whether it can instead be
> allocated once when the section is added?
I think we can store the bitmap buffer into the `state' where
`log_for_dirtybit' is already present, and free the bitmap when
`log_for_dirtybit' is cleared.
Thanks,
--
Anthony PERARD
- [Qemu-devel] [PATCH 0/4] Fix build of Xen support + cleanup, Anthony PERARD, 2019/06/17
- [Qemu-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c, Anthony PERARD, 2019/06/17
- Re: [Qemu-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c, Paul Durrant, 2019/06/17
- Re: [Qemu-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c, Anthony PERARD, 2019/06/17
- Re: [Qemu-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c, Paul Durrant, 2019/06/17
- Re: [Qemu-devel] [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c, Anthony PERARD, 2019/06/17
- Re: [Qemu-devel] [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c, Paul Durrant, 2019/06/18
- Re: [Qemu-devel] [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c, Anthony PERARD, 2019/06/18
[Qemu-devel] [PATCH 1/4] xen: Fix build with public headers, Anthony PERARD, 2019/06/17