qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v2 24/35] multi-process: add qdev_proxy_add


From: Elena Ufimtseva
Subject: Re: [Qemu-devel] [RFC PATCH v2 24/35] multi-process: add qdev_proxy_add to create proxy devices
Date: Mon, 17 Jun 2019 12:47:39 -0700
User-agent: Mutt/1.9.4 (2018-02-28)

On Mon, Jun 17, 2019 at 02:22:08PM -0500, Eric Blake wrote:
> On 6/17/19 1:16 PM, address@hidden wrote:
> > From: Elena Ufimtseva <address@hidden>
> > 
> > This is handled while parsing the command line options.
> > The parsed options are being sent to remote process
> > as the messgaes containing JSON strings.
> 
> s/messgaes/messages/
> 
> > 
> > Changes in v2:
> >  - parse socket and command suboptions of drive/device commands;
> 
> The changelog paragraph belongs...
> 
> > 
> > Signed-off-by: Jagannathan Raman <address@hidden>
> > Signed-off-by: John G Johnson <address@hidden>
> > Signed-off-by: Elena Ufimtseva <address@hidden>
> > ---
> 
> ...here, after the --- divider. It is useful to reviewers, but gets
> stripped by 'git am' when the maintainer applies the series. A year from
> now, we won't care how many iterations the patches went through on list,
> only the one version that got committed to git.
>

That one slipped trough with this, will fix.

> >  include/hw/proxy/qemu-proxy.h |   7 ++
> >  include/monitor/qdev.h        |   5 +
> >  qdev-monitor.c                | 166 ++++++++++++++++++++++++++++++++++
> >  3 files changed, 178 insertions(+)
> > 
> 
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org
> 






reply via email to

[Prev in Thread] Current Thread [Next in Thread]