Re: [Qemu-devel] [PULL 00/16] Monitor patches for 2019-06-17

[Markus Armbruster]

Peter Maydell <address@hidden> writes:

> On Mon, 17 Jun 2019 at 19:51, Markus Armbruster <address@hidden> wrote:
>>
>> The following changes since commit 076243ffe6c1b687e9e6d98348c3bf3398df78f3:
>>
>>   Merge remote-tracking branch 'remotes/pmaydell/tags/pull-docs-20190617' 
>> into staging (2019-06-17 16:41:25 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2019-06-17
>>
>> for you to fetch changes up to 092b8737c5e7695c4b9caa3b4eedc66763632755:
>>
>>   vl: Deprecate -mon pretty=... for HMP monitors (2019-06-17 20:36:56 +0200)
>>
>> ----------------------------------------------------------------
>> Monitor patches for 2019-06-17
>>
>
> Hi; I'm afraid this doesn't compile:
>
> Most hosts (ppc64, s390, aarch64, aarch32, osx, and possibly
> the others too though they haven't failed immediately) fail
> something like this:
>
> /home/pm215/qemu/monitor/misc.c: In function ‘netdev_del_completion’:
> /home/pm215/qemu/monitor/misc.c:2165:9: error: implicit declaration of
> function ‘qemu_find_opts_err’ [-Werror=implicit-function-declaration]
>          opts = qemu_opts_find(qemu_find_opts_err("netdev", NULL), name);
>          ^
> /home/pm215/qemu/monitor/misc.c:2165:9: error: nested extern
> declaration of ‘qemu_find_opts_err’ [-Werror=nested-externs]
> /home/pm215/qemu/monitor/misc.c:2165:9: error: passing argument 1 of
> ‘qemu_opts_find’ makes pointer from integer without a cast [-Werror]
> In file included from /home/pm215/qemu/monitor/misc.c:64:0:
> /home/pm215/qemu/include/qemu/option.h:105:11: note: expected ‘struct
> QemuOptsList *’ but argument is of type ‘int’
>  QemuOpts *qemu_opts_find(QemuOptsList *list, const char *id);
>            ^
> cc1: all warnings being treated as errors

Yup, my fault: I fell into the trap laid by include/ui/qemu-spice.h,
which includes qemu/config-file.h only when CONFIG_SPICE.

> windows is a bit different:
>
> /home/petmay01/qemu-for-merges/monitor/hmp.c: In function 'file_completion':
> /home/petmay01/qemu-for-merges/monitor/hmp.c:1113:5: error: unknown
> type name 'DIR'
>      DIR *ffs;
>      ^
> /home/petmay01/qemu-for-merges/monitor/hmp.c:1135:11: error: implicit
> declaration of function 'opendir'
> [-Werror=implicit-function-declaration]
>      ffs = opendir(path);
>            ^
> /home/petmay01/qemu-for-merges/monitor/hmp.c:1135:5: error: nested
> extern declaration of 'opendir' [-Werror=nested-externs]
>      ffs = opendir(path);
>      ^
> /home/petmay01/qemu-for-merges/monitor/hmp.c:1135:9: error: assignment
> makes pointer from integer without a cast [-Werror=int-conversion]
>      ffs = opendir(path);
>          ^
> /home/petmay01/qemu-for-merges/monitor/hmp.c:1141:13: error: implicit
> declaration of function 'readdir'
> [-Werror=implicit-function-declaration]
>          d = readdir(ffs);
>              ^
> /home/petmay01/qemu-for-merges/monitor/hmp.c:1141:9: error: nested
> extern declaration of 'readdir' [-Werror=nested-externs]
>          d = readdir(ffs);
>          ^
> /home/petmay01/qemu-for-merges/monitor/hmp.c:1141:11: error:
> assignment makes pointer from integer without a cast
> [-Werror=int-conversion]
>          d = readdir(ffs);
>            ^
> /home/petmay01/qemu-for-merges/monitor/hmp.c:1146:21: error:
> dereferencing pointer to incomplete type 'struct dirent'
>          if (strcmp(d->d_name, ".") == 0 || strcmp(d->d_name, "..") == 0) {
>                      ^
> /home/petmay01/qemu-for-merges/monitor/hmp.c:1166:5: error: implicit
> declaration of function 'closedir'
> [-Werror=implicit-function-declaration]
>      closedir(ffs);
>      ^
> /home/petmay01/qemu-for-merges/monitor/hmp.c:1166:5: error: nested
> extern declaration of 'closedir' [-Werror=nested-externs]

Here, Kevin fell into the trap laid by GLib, which includes <dirent.h>
only #ifdef G_OS_UNIX.

v2 coming up.