[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 16/16] vl: Deprecate -mon pretty=... for HMP moni
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PULL 16/16] vl: Deprecate -mon pretty=... for HMP monitors |
Date: |
Tue, 18 Jun 2019 10:01:53 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Mon, Jun 17, 2019 at 08:49:03PM +0200, Markus Armbruster wrote:
> From: Kevin Wolf <address@hidden>
>
> The -mon pretty=on|off switch of the -mon option applies only to QMP
> monitors. It's silently ignored for HMP. Deprecate this combination so
> that we can make it an error in future versions.
No objection to merging this PR as is, but how about we extend the
deprecation to QMP too ?
I was responsible for adding this option back in 2010 and I don't
think I've used it since 2012 when I added pretty printing support
to scripts/qmp/qmp-shell. I struggle to imagine good reasons for
using QMP directly with pretty printing, as opposed to doing it
via qmp-shell or another wrapper tool.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PULL 04/16] monitor: Make MonitorQMP a child class of Monitor, (continued)
- [Qemu-devel] [PULL 04/16] monitor: Make MonitorQMP a child class of Monitor, Markus Armbruster, 2019/06/17
- [Qemu-devel] [PULL 09/16] monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c, Markus Armbruster, 2019/06/17
- [Qemu-devel] [PULL 08/16] Move monitor.c to monitor/misc.c, Markus Armbruster, 2019/06/17
- [Qemu-devel] [PULL 14/16] monitor: Split Monitor.flags into separate bools, Markus Armbruster, 2019/06/17
- [Qemu-devel] [PULL 06/16] monitor: Remove Monitor.cmd_table indirection, Markus Armbruster, 2019/06/17
- [Qemu-devel] [PULL 02/16] monitor: Remove unused password prompting fields, Markus Armbruster, 2019/06/17
- [Qemu-devel] [PULL 11/16] monitor: Split out monitor/qmp.c, Markus Armbruster, 2019/06/17
- [Qemu-devel] [PULL 15/16] monitor: Replace monitor_init() with monitor_init_{hmp, qmp}(), Markus Armbruster, 2019/06/17
- [Qemu-devel] [PULL 05/16] monitor: Create MonitorHMP with readline state, Markus Armbruster, 2019/06/17
- [Qemu-devel] [PULL 16/16] vl: Deprecate -mon pretty=... for HMP monitors, Markus Armbruster, 2019/06/17
- Re: [Qemu-devel] [PULL 16/16] vl: Deprecate -mon pretty=... for HMP monitors,
Daniel P . Berrangé <=
[Qemu-devel] [PULL 07/16] monitor: Rename HMP command type and tables, Markus Armbruster, 2019/06/17
[Qemu-devel] [PULL 13/16] monitor: Split out monitor/monitor.c, Markus Armbruster, 2019/06/17
[Qemu-devel] [PULL 12/16] monitor: Split out monitor/hmp.c, Markus Armbruster, 2019/06/17
[Qemu-devel] [PULL 10/16] monitor: Create monitor-internal.h with common definitions, Markus Armbruster, 2019/06/17
Re: [Qemu-devel] [PULL 00/16] Monitor patches for 2019-06-17, Peter Maydell, 2019/06/17