Re: [Qemu-devel] [SeaBIOS] [QEMU] [PATCH v4 0/8] Add Qemu to SeaBIOS LCHS interface

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [SeaBIOS] [QEMU] [PATCH v4 0/8] Add Qemu to SeaBIOS LCHS interface
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
4060750 hd-geo-test: Add tests for lchs override
ec0929e bootdevice: FW_CFG interface for LCHS values
9106987 bootdevice: Refactor get_boot_devices_list
fe6a0c0 bootdevice: Gather LCHS from all relevant devices
f68a15e scsi: Propagate unrealize() callback to scsi-hd
1347e7f bootdevice: Add interface to gather LCHS
2fcd94d block: Support providing LCHS from user
43c0cdf block: Refactor macros - fix tabbing

=== OUTPUT BEGIN ===
1/8 Checking commit 43c0cdf73c6a (block: Refactor macros - fix tabbing)
ERROR: Macros with complex values should be enclosed in parenthesis
#55: FILE: include/hw/block/block.h:65:
+#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf)                      \
+    DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0),                  \
+    DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0),                \
     DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)

total: 1 errors, 0 warnings, 37 lines checked

Patch 1/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/8 Checking commit 2fcd94d78d62 (block: Support providing LCHS from user)
3/8 Checking commit 1347e7f38d62 (bootdevice: Add interface to gather LCHS)
4/8 Checking commit f68a15e41072 (scsi: Propagate unrealize() callback to 
scsi-hd)
5/8 Checking commit fe6a0c0ad0de (bootdevice: Gather LCHS from all relevant 
devices)
6/8 Checking commit 9106987ba4fa (bootdevice: Refactor get_boot_devices_list)
7/8 Checking commit ec0929e04764 (bootdevice: FW_CFG interface for LCHS values)
8/8 Checking commit 4060750b63c9 (hd-geo-test: Add tests for lchs override)
WARNING: line over 80 characters
#242: FILE: tests/hd-geo-test.c:579:
+                     (char *)r->dev_path, &(r->chs.c), &(r->chs.h), 
&(r->chs.s));

WARNING: Block comments use a leading /* on a separate line
#640: FILE: tests/hd-geo-test.c:995:
+                       "skipping hd-geo/override/* tests");

total: 0 errors, 2 warnings, 608 lines checked

Patch 8/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden