Re: [Qemu-devel] Recent python-sphinx errors out building doc

[John Snow]

On 6/19/19 2:15 PM, John Snow wrote:
> 
> 
> On 6/19/19 12:28 AM, Bruce Rogers wrote:
>>>>> On 6/18/2019 at 6:11 PM, John Snow <address@hidden> wrote:
>>
>>>
>>> On 6/18/19 7:37 PM, Bruce Rogers wrote:
>>>> Hi,
>>>>
>>>> (Resent with correct address for John)
>>>> I build recent upstream qemu in the openSUSE Build Service, and for
>>>> the Factory repository there, python-sphinx was recently updated to
>>>> version 2.1.1. This caused the build to fail as follows:
>>>> /home/abuild/rpmbuild/BUILD/qemu-4.0.50/docs/interop/bitmaps.rst:202:Could
>>>> not lex literal_block as "json". Highlighting skipped.
>>>>
>>>> The python-sphinx tools is called with warnings are treated as errors
>>>> it looks like. I don't know much at all about this tool, and hopefully
>>>> someone knows what to fix here. If you want to give me a pointer
>>>> on what needs to change, I could give a go at doing a fix however.
>>>>
>>>> Thanks,
>>>>
>>>> Bruce
>>>
>>> Hi, there's a series designed to fix this:
>>>
>>> https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg00348.html 
>>>
>>> I think it's up to Peter to merge it as the maintainer of the Sphinx
>>> machinery.
>>
>> Yup, this series fixes it for me. Thanks!
>>
>> Bruce
>>
> 
> Correction: Peter already merged it. Sorry for the noise!
> 

... Double correction, I misread the patch titles and it isn't merged.
Nobody should ever let me email before about 3-4PM EST, because my brain
isn't awake enough yet.

...Sorry for the noise 2x...

Peter, is the series ready for staging? I don't think the docs portion
needs any additional review beyond what it's already received.

--js