qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/17] qom: Move QMP command handlers to qom/


From: Daniel P . Berrangé
Subject: Re: [Qemu-devel] [PATCH 05/17] qom: Move QMP command handlers to qom/
Date: Thu, 20 Jun 2019 09:35:43 +0100
User-agent: Mutt/1.11.4 (2019-03-13)

On Wed, Jun 19, 2019 at 10:10:38PM +0200, Markus Armbruster wrote:
> The handlers for qapi/qom.json's QMP commands are in
> monitor/qmp-cmds.c.  Move them to new qom/qom-qmp-cmds.c, where they
> are covered by MAINTAINERS section QOM, just like qapi/qom.json.
> 
> Move along qmp_device_list_properties() even though it's specified in
> qapi/qdev.json, because it's so similar to qmp_qom_list_properties().
> 
> Cc: Paolo Bonzini <address@hidden>
> Cc: "Daniel P. Berrange" <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  monitor/qmp-cmds.c | 303 ------------------------------------------
>  qom/Makefile.objs  |   1 +
>  qom/qom-qmp-cmds.c | 323 +++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 324 insertions(+), 303 deletions(-)
>  create mode 100644 qom/qom-qmp-cmds.c

Reviewed-by: Daniel P. Berrangé <address@hidden>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]