Re: [Qemu-devel] [PATCH 04/17] qapi: Split qom.json and qdev.json off misc.json

[Daniel P . Berrangé]

On Wed, Jun 19, 2019 at 10:10:37PM +0200, Markus Armbruster wrote:
> Move commands object-add, object-del, qom-get, qom-list,
> qom-list-properties, qom-list-types, and qom-set with their types from
> misc.json to new qom.json.  Add qom.json to MAINTAINERS section QOM.
> 
> Move commands device-list-properties, device_add, device-del, and
> event DEVICE_DELETED from misc.json to new qdev.json.  qdev.json
> remains uncovered by MAINTAINERS, like the rest of qdev.
> 
> Cc: Paolo Bonzini <address@hidden>
> Cc: "Daniel P. Berrange" <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  MAINTAINERS           |   1 +
>  hw/block/xen-block.c  |   2 +-
>  hw/core/qdev.c        |   2 +-
>  monitor/hmp-cmds.c    |   1 +
>  monitor/qmp-cmds.c    |   1 +
>  qapi/Makefile.objs    |   5 +-
>  qapi/misc.json        | 351 ------------------------------------------
>  qapi/qapi-schema.json |   2 +
>  qapi/qdev.json        | 125 +++++++++++++++
>  qapi/qom.json         | 244 +++++++++++++++++++++++++++++
>  qdev-monitor.c        |   2 +-
>  11 files changed, 380 insertions(+), 356 deletions(-)
>  create mode 100644 qapi/qdev.json
>  create mode 100644 qapi/qom.json

Reviewed-by: Daniel P. Berrangé <address@hidden>

> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 63390eadb5..1aef0afaf7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2035,6 +2035,7 @@ R: Eduardo Habkost <address@hidden>
>  S: Supported
>  F: include/qom/
>  X: include/qom/cpu.h
> +F: qapi/qom.json
>  F: qom/
>  X: qom/cpu.c
>  F: tests/check-qom-interface.c

So we don't have any designated "qdev" maintainers i see.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|