Re: [Qemu-devel] [PATCH v3 37/50] translator: inject instrumentation from plugins

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> On 6/14/19 10:11 AM, Alex Bennée wrote:
>> @@ -95,6 +103,10 @@ void translator_loop(const TranslatorOps *ops, 
>> DisasContextBase *db,
>>              ops->translate_insn(db, cpu);
>>          }
>>
>> +        if (plugin_enabled) {
>> +            plugin_gen_insn_end();
>> +        }
>> +
>>          /* Stop translation if translate_insn so indicated.  */
>>          if (db->is_jmp != DISAS_NEXT) {
>
> This will of course not be reachable if db->is_jmp == DISAS_NORETURN.
> Do we want to not bother calling the plugin for this case?

Hmm good point. Are you just suggesting:

  if (plugin_enabled && db->is_jmp != DISAS_NORETURN)

to be explicit?

>
>
> r~


--
Alex Bennée