Re: [Qemu-devel] [PULL 00/25] Misc (mostly x86) patches for 2019-06-21

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/25] Misc (mostly x86) patches for 2019-06-21
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
40d8d2a6bd hw: Nuke hw_compat_4_0_1 and pc_compat_4_0_1
73fe0889f4 util/main-loop: Fix incorrect assertion
618fd44d79 sd: Fix out-of-bounds assertions
d3c8dae021 target/i386: kvm: Add nested migration blocker only when kernel 
lacks required capabilities
31293fcc83 target/i386: kvm: Add support for KVM_CAP_EXCEPTION_PAYLOAD
c86b7f9ea7 target/i386: kvm: Add support for save and restore nested state
74af141e76 vmstate: Add support for kernel integer types
7fb006f6dc linux-headers: sync with latest KVM headers from Linux 5.2
b0e72dd5be target/i386: kvm: Block migration for vCPUs exposed with nested 
virtualization
6eb6ee733d target/i386: kvm: Re-inject #DB to guest with updated DR6
063779b466 target/i386: kvm: Use symbolic constant for #DB/#BP exception 
constants
0d5f1db3f3 KVM: Introduce kvm_arch_destroy_vcpu()
8410943162 target/i386: kvm: Delete VMX migration blocker on vCPU init failure
7d269c7b25 target/i386: define a new MSR based feature word - 
FEAT_CORE_CAPABILITY
48a660ddf1 i386/kvm: add support for Direct Mode for Hyper-V synthetic timers
4c286bb0f0 i386/kvm: hv-evmcs requires hv-vapic
b0a84ac0f3 i386/kvm: hv-tlbflush/ipi require hv-vpindex
67ae163697 i386/kvm: hv-stimer requires hv-time and hv-synic
c4235a20e3 i386/kvm: implement 'hv-passthrough' mode
9b41ec1de0 i386/kvm: document existing Hyper-V enlightenments
644d910def i386/kvm: move Hyper-V CPUID filling to hyperv_handle_properties()
cf3f383dc6 i386/kvm: add support for KVM_GET_SUPPORTED_HV_CPUID
03b1cb7339 i386/kvm: convert hyperv enlightenments properties from bools to bits
31a2b079aa hax: Honor CPUState::halted
4ff0d94d19 kvm-all: Add/update fprintf's for kvm_*_ioeventfd_del

=== OUTPUT BEGIN ===
1/25 Checking commit 4ff0d94d1917 (kvm-all: Add/update fprintf's for 
kvm_*_ioeventfd_del)
2/25 Checking commit 31a2b079aaf9 (hax: Honor CPUState::halted)
WARNING: Block comments use a leading /* on a separate line
#77: FILE: target/i386/hax-all.c:479:
+    /* After a vcpu is halted (either because it is an AP and has just been

WARNING: Block comments use a leading /* on a separate line
#109: FILE: target/i386/hax-all.c:519:
+        /* If this vcpu is halted, we must not ask HAXM to run it. Instead, we

total: 0 errors, 2 warnings, 60 lines checked

Patch 2/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/25 Checking commit 03b1cb733929 (i386/kvm: convert hyperv enlightenments 
properties from bools to bits)
4/25 Checking commit cf3f383dc652 (i386/kvm: add support for 
KVM_GET_SUPPORTED_HV_CPUID)
5/25 Checking commit 644d910def82 (i386/kvm: move Hyper-V CPUID filling to 
hyperv_handle_properties())
6/25 Checking commit 9b41ec1de0ee (i386/kvm: document existing Hyper-V 
enlightenments)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 181 lines checked

Patch 6/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/25 Checking commit c4235a20e312 (i386/kvm: implement 'hv-passthrough' mode)
8/25 Checking commit 67ae163697ff (i386/kvm: hv-stimer requires hv-time and 
hv-synic)
9/25 Checking commit b0a84ac0f3fa (i386/kvm: hv-tlbflush/ipi require hv-vpindex)
10/25 Checking commit 4c286bb0f0d4 (i386/kvm: hv-evmcs requires hv-vapic)
11/25 Checking commit 48a660ddf1ab (i386/kvm: add support for Direct Mode for 
Hyper-V synthetic timers)
12/25 Checking commit 7d269c7b257f (target/i386: define a new MSR based feature 
word - FEAT_CORE_CAPABILITY)
13/25 Checking commit 841094316237 (target/i386: kvm: Delete VMX migration 
blocker on vCPU init failure)
14/25 Checking commit 0d5f1db3f3b8 (KVM: Introduce kvm_arch_destroy_vcpu())
ERROR: code indent should never use tabs
#61: FILE: target/arm/kvm32.c:245:
+^Ireturn 0;$

ERROR: g_free(NULL) is safe this check is probably not required
#96: FILE: target/i386/kvm.c:1687:
+    if (cpu->kvm_msr_buf) {
+        g_free(cpu->kvm_msr_buf);

total: 2 errors, 0 warnings, 96 lines checked

Patch 14/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/25 Checking commit 063779b4664d (target/i386: kvm: Use symbolic constant for 
#DB/#BP exception constants)
16/25 Checking commit 6eb6ee733d73 (target/i386: kvm: Re-inject #DB to guest 
with updated DR6)
17/25 Checking commit b0e72dd5be66 (target/i386: kvm: Block migration for vCPUs 
exposed with nested virtualization)
ERROR: return is not a function, parentheses are not required
#64: FILE: target/i386/cpu.h:1860:
+    return (env->features[FEAT_1_ECX] & CPUID_EXT_VMX);

ERROR: return is not a function, parentheses are not required
#69: FILE: target/i386/cpu.h:1865:
+    return (env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_SVM);

ERROR: return is not a function, parentheses are not required
#74: FILE: target/i386/cpu.h:1870:
+    return (cpu_has_vmx(env) || cpu_has_svm(env));

total: 3 errors, 0 warnings, 80 lines checked

Patch 17/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/25 Checking commit 7fb006f6dcfa (linux-headers: sync with latest KVM headers 
from Linux 5.2)
19/25 Checking commit 74af141e7640 (vmstate: Add support for kernel integer 
types)
20/25 Checking commit c86b7f9ea7d3 (target/i386: kvm: Add support for save and 
restore nested state)
ERROR: g_free(NULL) is safe this check is probably not required
#130: FILE: target/i386/kvm.c:1712:
+    if (env->nested_state) {
+        g_free(env->nested_state);

ERROR: spaces required around that '*' (ctx:VxV)
#316: FILE: target/i386/machine.c:935:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

ERROR: return is not a function, parentheses are not required
#345: FILE: target/i386/machine.c:964:
+    return (env->nested_state &&

ERROR: spaces required around that '*' (ctx:VxV)
#407: FILE: target/i386/machine.c:1026:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

total: 4 errors, 0 warnings, 386 lines checked

Patch 20/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

21/25 Checking commit 31293fcc8317 (target/i386: kvm: Add support for 
KVM_CAP_EXCEPTION_PAYLOAD)
ERROR: code indent should never use tabs
#137: FILE: target/i386/kvm.c:590:
+^Ienv->exception_nr = -1;$

ERROR: code indent should never use tabs
#138: FILE: target/i386/kvm.c:591:
+^Ienv->exception_pending = 0;$

ERROR: code indent should never use tabs
#139: FILE: target/i386/kvm.c:592:
+^Ienv->exception_injected = 0;$

ERROR: code indent should never use tabs
#140: FILE: target/i386/kvm.c:593:
+^Ienv->exception_has_payload = false;$

ERROR: code indent should never use tabs
#141: FILE: target/i386/kvm.c:594:
+^Ienv->exception_payload = 0;$

ERROR: code indent should never use tabs
#363: FILE: target/i386/machine.c:342:
+     *^I  pending or guest wasn't running L2 (See comment in cpu_pre_save()).$

ERROR: return is not a function, parentheses are not required
#392: FILE: target/i386/machine.c:409:
+    return (env->exception_pending && (env->hflags & HF_GUEST_MASK));

total: 7 errors, 0 warnings, 353 lines checked

Patch 21/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

22/25 Checking commit d3c8dae021fb (target/i386: kvm: Add nested migration 
blocker only when kernel lacks required capabilities)
23/25 Checking commit 618fd44d794c (sd: Fix out-of-bounds assertions)
24/25 Checking commit 73fe0889f412 (util/main-loop: Fix incorrect assertion)
25/25 Checking commit 40d8d2a6bd2b (hw: Nuke hw_compat_4_0_1 and 
pc_compat_4_0_1)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden