Re: [Qemu-devel] [PATCH for-4.1 00/24] Fix record/replay and add reverse debugging

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/156110523748.25431.9310430853468653085.stgit@pasha-Precision-3630-Tower/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH for-4.1 00/24] Fix record/replay and add reverse 
debugging
Type: series
Message-id: 
156110523748.25431.9310430853468653085.stgit@pasha-Precision-3630-Tower

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               
patchew/156110523748.25431.9310430853468653085.stgit@pasha-Precision-3630-Tower 
-> 
patchew/156110523748.25431.9310430853468653085.stgit@pasha-Precision-3630-Tower
Switched to a new branch 'test'
adb83324f9 icount: clean up cpu_can_io before jumping to the next block
b707ea6a2b replay: rename step-related variables and functions
1d080b473c replay: fix replay shutdown
59212a6234 util/qemu-timer: refactor deadline calculation for external timers
eaccfbb566 replay: document development rules
0be10699ff replay: add BH oneshot event for block layer
d025976b68 replay: describe reverse debugging in docs/replay.txt
a261132db8 gdbstub: add reverse continue support in replay mode
b31ce9d399 gdbstub: add reverse step support in replay mode
f2b3c4a828 replay: flush rr queue before loading the vmstate
f2d2d121b3 replay: refine replay-time module
0b02e3b0cc replay: implement replay-seek command
84e592947f replay: introduce breakpoint at the specified step
cdc1e61eb2 replay: introduce info hmp/qmp command
d7f6b22099 qapi: introduce replay.json for record/replay-related stuff
52c7b50aa8 replay: provide an accessor for rr filename
b7407e35d5 migration: introduce icount field for snapshots
f8bce7c87f qcow2: introduce icount field for snapshots
65eb56e3d8 replay: finish record/replay before closing the disks
edd54d2741 replay: don't drain/flush bdrv queue while RR is working
9095208014 replay: update docs for record/replay with block devices
c0ebe8273d replay: disable default snapshot for record/replay
3b0235d499 block: implement bdrv_snapshot_goto for blkreplay
3582d31d0d replay: add missing fix for internal function

=== OUTPUT BEGIN ===
1/24 Checking commit 3582d31d0d97 (replay: add missing fix for internal 
function)
2/24 Checking commit 3b0235d499e6 (block: implement bdrv_snapshot_goto for 
blkreplay)
3/24 Checking commit c0ebe8273d27 (replay: disable default snapshot for 
record/replay)
4/24 Checking commit 9095208014bf (replay: update docs for record/replay with 
block devices)
5/24 Checking commit edd54d274191 (replay: don't drain/flush bdrv queue while 
RR is working)
6/24 Checking commit 65eb56e3d888 (replay: finish record/replay before closing 
the disks)
7/24 Checking commit f8bce7c87f5e (qcow2: introduce icount field for snapshots)
8/24 Checking commit b7407e35d5b0 (migration: introduce icount field for 
snapshots)
9/24 Checking commit 52c7b50aa8f2 (replay: provide an accessor for rr filename)
10/24 Checking commit d7f6b220997f (qapi: introduce replay.json for 
record/replay-related stuff)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#101: 
new file mode 100644

total: 0 errors, 1 warnings, 80 lines checked

Patch 10/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/24 Checking commit cdc1e61eb21c (replay: introduce info hmp/qmp command)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#142: 
new file mode 100644

total: 0 errors, 1 warnings, 127 lines checked

Patch 11/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/24 Checking commit 84e592947ff8 (replay: introduce breakpoint at the 
specified step)
13/24 Checking commit 0b02e3b0ccd0 (replay: implement replay-seek command)
14/24 Checking commit f2d2d121b365 (replay: refine replay-time module)
15/24 Checking commit f2b3c4a82866 (replay: flush rr queue before loading the 
vmstate)
16/24 Checking commit b31ce9d3992b (gdbstub: add reverse step support in replay 
mode)
17/24 Checking commit a261132db89f (gdbstub: add reverse continue support in 
replay mode)
ERROR: line over 90 characters
#71: FILE: gdbstub.c:2131:
+        pstrcat(gdb_ctx->str_buf, sizeof(gdb_ctx->str_buf), 
";ReverseStep+;ReverseContinue+");

total: 1 errors, 0 warnings, 146 lines checked

Patch 17/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/24 Checking commit d025976b680a (replay: describe reverse debugging in 
docs/replay.txt)
19/24 Checking commit 0be10699ffd9 (replay: add BH oneshot event for block 
layer)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#317: 
new file mode 100644

total: 0 errors, 1 warnings, 224 lines checked

Patch 19/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/24 Checking commit eaccfbb5661f (replay: document development rules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 46 lines checked

Patch 20/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/24 Checking commit 59212a623425 (util/qemu-timer: refactor deadline 
calculation for external timers)
22/24 Checking commit 1d080b473cb2 (replay: fix replay shutdown)
23/24 Checking commit b707ea6a2b99 (replay: rename step-related variables and 
functions)
24/24 Checking commit adb83324f96a (icount: clean up cpu_can_io before jumping 
to the next block)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/156110523748.25431.9310430853468653085.stgit@pasha-Precision-3630-Tower/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden