Re: [Qemu-devel] [PATCH 0/2] target/i386: kvm: Fix treatment of AMD SVM in nested migration

[Liran Alon]

> On 22 Jun 2019, at 5:39, address@hidden wrote:
> 
> Patchew URL: 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchew.org_QEMU_20190621213712.16222-2D1-2Dliran.alon-40oracle.com_&d=DwIGaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=Jk6Q8nNzkQ6LJ6g42qARkg6ryIDGQr-yKXPNGZbpTx0&m=XheZ4_IReq-ruli16BfJeGb3_F7yec8LhFweZ5i6zf8&s=ZYZOCSnRRy8FBDWmZ7sm21_IHQoZJHKXDo6_GHyY6xo&e=
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Subject: [Qemu-devel] [PATCH 0/2] target/i386: kvm: Fix treatment of AMD SVM 
> in nested migration
> Type: series
> Message-id: address@hidden
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> From 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_patchew-2Dproject_qemu&d=DwIGaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=Jk6Q8nNzkQ6LJ6g42qARkg6ryIDGQr-yKXPNGZbpTx0&m=XheZ4_IReq-ruli16BfJeGb3_F7yec8LhFweZ5i6zf8&s=QFR1iC1wuS3a7nr5wT0nl1N49SaJCGcwFH_g0Uv7FrU&e=
> * [new tag]               patchew/address@hidden -> patchew/address@hidden
> Switched to a new branch 'test'
> a5de9408a8 target/i386: kvm: Init nested-state in case of vCPU exposed with 
> SVM
> 06ca99d907 target/i386: kvm: Block migration on vCPU exposed with SVM when 
> kernel lacks caps to save/restore nested state
> 
> === OUTPUT BEGIN ===
> 1/2 Checking commit 06ca99d907bc (target/i386: kvm: Block migration on vCPU 
> exposed with SVM when kernel lacks caps to save/restore nested state)
> ERROR: return is not a function, parentheses are not required
> #46: FILE: target/i386/cpu.h:1877:
> +    return (cpu_has_vmx(env) || cpu_has_svm(env));
> 
> total: 1 errors, 0 warnings, 32 lines checked
> 
> Patch 1/2 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 2/2 Checking commit a5de9408a89a (target/i386: kvm: Init nested-state in case 
> of vCPU exposed with SVM)
> === OUTPUT END ===

I kinda disagree that adding parentheses at return statements is a bad thing…
Why do we enforce such a coding convention?

Anyway, I think this can be fixed when applying if we decide to apply this.

-Liran