[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*
|
From: |
Kevin O'Connor |
|
Subject: |
Re: [Qemu-devel] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions |
|
Date: |
Sat, 22 Jun 2019 11:27:24 -0400 |
|
User-agent: |
Mutt/1.11.3 (2019-02-01) |
On Sat, Jun 22, 2019 at 11:51:48AM +0300, Sam Eiderman wrote:
> But maybe someone wants bootorder but doesn’t want to override legacy disk
> translations…
>
> I’m thinking of maybe adding
>
> if (!CONFIG_BOOTORDER || !CONFIG_BIOS_GEOMETRY)
> return NULL;
That's fine - though it's (!CONFIG_BOOTORDER && !CONFIG_BIOS_GEOMETRY).
FYI, I think BIOS_GEOMETRY is a little confusing - maybe
CUSTOM_DISK_GEOMETRY.
-Kevin
- [Qemu-devel] [SeaBIOS] [PATCH v3 2/4] boot: Reorder functions in boot.c, (continued)
- [Qemu-devel] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions, Sam Eiderman, 2019/06/19
- Re: [Qemu-devel] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions, Kevin O'Connor, 2019/06/20
- Re: [Qemu-devel] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions, Sam Eiderman, 2019/06/21
- Re: [Qemu-devel] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions, Kevin O'Connor, 2019/06/21
- Re: [Qemu-devel] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions, Sam Eiderman, 2019/06/22
- Re: [Qemu-devel] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions,
Kevin O'Connor <=
- Re: [Qemu-devel] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions, Sam Eiderman, 2019/06/22
- Re: [Qemu-devel] [SeaBIOS] [PATCH v3 3/4] geometry: Add boot_lchs_find_*() utility functions, Sam Eiderman, 2019/06/26