Re: [Qemu-devel] [PATCH v5 00/16] tcg/ppc: Add vector opcodes

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v5 00/16] tcg/ppc: Add vector opcodes
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
22d133b7d3 tcg/ppc: Update vector support to v3.00
90bbf51163 tcg/ppc: Update vector support to v2.07
b5335688c8 tcg/ppc: Update vector support to v2.06
b521901488 tcg/ppc: Support vector dup2
8924e68f97 tcg/ppc: Support vector multiply
e293fff80b tcg/ppc: Support vector shift by immediate
f690223722 tcg/ppc: Add empty file tcg-target.opc.h
e4e6419f8c tcg/ppc: Prepare case for vector multiply
7957f8f41c tcg/ppc: Add support for vector saturated add/subtract
fe805396ae tcg/ppc: Add support for vector add/subtract
5cb6cd0fc0 tcg/ppc: Add support for vector maximum/minimum
4747cecdb1 tcg/ppc: Add support for load/store/logic/comparison
421bc6d7d3 tcg/ppc: Introduce macros VRT(), VRA(), VRB(), VRC()
0379705f8d tcg/ppc: Introduce macro VX4()
7fc4554647 tcg/ppc: Introduce flag have_isa_altivec
29c55ddd9f tcg/ppc: Introduce Altivec registers

=== OUTPUT BEGIN ===
1/16 Checking commit 29c55ddd9f2e (tcg/ppc: Introduce Altivec registers)
2/16 Checking commit 7fc455464789 (tcg/ppc: Introduce flag have_isa_altivec)
3/16 Checking commit 0379705f8d31 (tcg/ppc: Introduce macro VX4())
ERROR: spaces required around that '|' (ctx:VxV)
#21: FILE: tcg/ppc/tcg-target.inc.c:323:
+#define VX4(opc)  (OPCD(4)|(opc))
                           ^

total: 1 errors, 0 warnings, 7 lines checked

Patch 3/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/16 Checking commit 421bc6d7d308 (tcg/ppc: Introduce macros VRT(), VRA(), 
VRB(), VRC())
5/16 Checking commit 4747cecdb1b0 (tcg/ppc: Add support for 
load/store/logic/comparison)
6/16 Checking commit 5cb6cd0fc043 (tcg/ppc: Add support for vector 
maximum/minimum)
7/16 Checking commit fe805396aee3 (tcg/ppc: Add support for vector add/subtract)
8/16 Checking commit 7957f8f41c63 (tcg/ppc: Add support for vector saturated 
add/subtract)
9/16 Checking commit e4e6419f8c88 (tcg/ppc: Prepare case for vector multiply)
10/16 Checking commit f69022372202 (tcg/ppc: Add empty file tcg-target.opc.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#19: FILE: tcg/ppc/tcg-target.opc.h:1:
+/* Target-specific opcodes for host vector expansion.  These will be

WARNING: Block comments use * on subsequent lines
#20: FILE: tcg/ppc/tcg-target.opc.h:2:
+/* Target-specific opcodes for host vector expansion.  These will be
+   emitted by tcg_expand_vec_op.  For those familiar with GCC internals,

WARNING: Block comments use a trailing */ on a separate line
#21: FILE: tcg/ppc/tcg-target.opc.h:3:
+   consider these to be UNSPEC with names.  */

total: 0 errors, 4 warnings, 3 lines checked

Patch 10/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/16 Checking commit e293fff80b39 (tcg/ppc: Support vector shift by immediate)
12/16 Checking commit 8924e68f97c6 (tcg/ppc: Support vector multiply)
ERROR: code indent should never use tabs
#133: FILE: tcg/ppc/tcg-target.inc.c:3219:
+^Ibreak;$

total: 1 errors, 0 warnings, 185 lines checked

Patch 12/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/16 Checking commit b52190148845 (tcg/ppc: Support vector dup2)
14/16 Checking commit b5335688c827 (tcg/ppc: Update vector support to v2.06)
15/16 Checking commit 90bbf5116349 (tcg/ppc: Update vector support to v2.07)
16/16 Checking commit 22d133b7d326 (tcg/ppc: Update vector support to v3.00)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden