Re: [Qemu-devel] [PATCH 16/17] MAINTAINERS: Add Windows dump to section "Dump"

[Markus Armbruster]

Daniel P. Berrangé <address@hidden> writes:

> On Wed, Jun 19, 2019 at 10:10:49PM +0200, Markus Armbruster wrote:
>> Commit 2da91b54fe9 "dump: add Windows dump format to
>> dump-guest-memory" neglected to update MAINTAINERS.  Do it now.
>> 
>> Cc: Marc-André Lureau <address@hidden>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  MAINTAINERS | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index a3fdda015f..327ad80ae4 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1850,9 +1850,10 @@ F: include/sysemu/device_tree.h
>>  Dump
>>  S: Supported
>>  M: Marc-André Lureau <address@hidden>
>> -F: dump/dump.c
>> +F: dump/
>
> Isn't this better squashed in the previous patch in fact.

If I do that, the commit does two things: move code and improve
MAINTAINERS coverage.  Okay in this case.  We can just as well finish
the improvement job then, i.e. squash the entire commit into the
previous one.

>>  F: hw/misc/vmcoreinfo.c
>>  F: include/hw/misc/vmcoreinfo.h
>> +F: include/qemu/win_dump_defs
>>  F: include/sysemu/dump-arch.h
>>  F: include/sysemu/dump.h
>>  F: qapi/dump.json
>
> Either way, the result is good so
>
> Reviewed-by: Daniel P. Berrangé <address@hidden>

Thanks!