Re: [Qemu-devel] [PULL 03/25] i386/kvm: convert hyperv enlightenments properties from bools to bits

[Alex Bennée]

Vitaly Kuznetsov <address@hidden> writes:

> Alex Bennée <address@hidden> writes:
>
>>
>> This looks like it's broken the build:
>>
>>   configure' '--without-default-devices' '--disable-user'
>>
>> with:
>>
>>   /home/alex/lsrc/qemu.git/target/i386/hyperv-stub.c: In function 
>> ‘kvm_hv_handle_exit’:
>>   /home/alex/lsrc/qemu.git/target/i386/hyperv-stub.c:18:19: error: ‘X86CPU’ 
>> {aka ‘struct X86CPU’} has no member named ‘hyperv_synic’; did you mean 
>> ‘hyperv_vendor_id’?
>>            if (!cpu->hyperv_synic) {
>>                      ^~~~~~~~~~~~
>>
>> Does the stub need updating for the new flag? I'm a little confused
>> about the relationship between HyperV and KVM. I thought they were
>> different hypervisors?
>
> Yes, they are. But to run Windows guests we can pretend being Hyper-V
> :-)
>
> I'll send a patch to fix the stub if nobody beats me to it. Thanks!

See:

  Subject: [PATCH] target/i386: fix feature check in hyperv-stub.c
  Date: Mon, 24 Jun 2019 13:38:35 +0100
  Message-Id: <address@hidden>

And let me know if it is correct. I'll include it in testing/next as
it is a build fix.

--
Alex Bennée