|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap |
Date: | Mon, 24 Jun 2019 15:21:12 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 24/06/19 14:48, Auger Eric wrote: >>>> + if (alignment <= size) { >>>> + /* Increase the alignment of start */ >>> I don't really get this comment >> This comment comes from Paolo, but I'll try to explain - it tries to >> mean that this "alignment" will be used as an increasement to "start" >> variable, so finally variable "start" will align with larger mask >> size. >> >> Better comments welcomed... :) > smallest page mask from @start or gaw? What it means is that there will be "more 0 bits" at the beginning of start. Perhaps "On the next iteration start will be aligned to a bigger power of two"? I can do this when applying. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |